CP-22009 Add CBT enable/disable operations to datamodel

And add checks for these VDI operations that determine whether whether
they are allowed on a given VDI.

Signed-off-by: Thomas Sanders <[email protected]>

Author: thomassa

ocaml/idl/datamodel.ml

@@ -5987,6 +5987,8 @@ let storage_operations =
           "vdi_clone", "Cloneing a VDI";
           "vdi_snapshot", "Snapshotting a VDI";
           "vdi_mirror", "Mirroring a VDI";
+          "vdi_enable_cbt", "Enabling changed block tracking for a VDI";
+          "vdi_disable_cbt", "Disabling changed block tracking for a VDI";
           "pbd_create", "Creating a PBD for this SR";
           "pbd_destroy", "Destroying one of this SR's PBDs"; ])
 
@@ -6309,6 +6311,8 @@ let vdi_operations =
           "update", "Refreshing the fields of the VDI";
           "force_unlock", "Forcibly unlocking the VDI";
           "generate_config", "Generating static configuration";
+          "enable_cbt", "Enabling changed block tracking for a VDI";
+          "disable_cbt", "Disabling changed block tracking for a VDI";
           "blocked", "Operations on this VDI are temporarily blocked";
         ])
 

ocaml/xapi/record_util.ml

@@ -97,7 +97,7 @@ let host_operation_to_string = function
   | `vm_resume -> "VM.resume"
   | `vm_migrate -> "VM.migrate"
 
-let vdi_operation_to_string = function
+let vdi_operation_to_string: API.vdi_operations -> string = function
   | `scan -> "scan"
   | `clone -> "clone"
   | `copy -> "copy"
@@ -110,9 +110,11 @@ let vdi_operation_to_string = function
   | `forget -> "forget"
   | `update -> "update"
   | `generate_config -> "generate_config"
+  | `enable_cbt -> "enable_cbt"
+  | `disable_cbt -> "disable_cbt"
   | `blocked -> "blocked"
 
-let sr_operation_to_string = function
+let sr_operation_to_string: API.storage_operations -> string = function
   | `scan -> "scan"
   | `destroy -> "destroy"
   | `forget -> "forget"
@@ -126,6 +128,8 @@ let sr_operation_to_string = function
   | `vdi_clone -> "VDI.clone"
   | `vdi_snapshot -> "VDI.snapshot"
   | `vdi_mirror -> "VDI.mirror"
+  | `vdi_enable_cbt -> "VDI.enable_cbt"
+  | `vdi_disable_cbt -> "VDI.disable_cbt"
   | `pbd_create -> "PBD.create"
   | `pbd_destroy -> "PBD.destroy"
 

ocaml/xapi/xapi_sr_operations.ml

@@ -37,14 +37,16 @@ open Record_util
 
 let all_ops : API.storage_operations_set =
   [ `scan; `destroy; `forget; `plug; `unplug; `vdi_create; `vdi_destroy; `vdi_resize; `vdi_clone; `vdi_snapshot; `vdi_mirror;
-    `vdi_introduce; `update; `pbd_create; `pbd_destroy ]
+    `vdi_enable_cbt; `vdi_disable_cbt; `vdi_introduce; `update; `pbd_create; `pbd_destroy ]
 
 let sm_cap_table =
   [ `vdi_create, Smint.Vdi_create;
     `vdi_destroy, Smint.Vdi_delete;
     `vdi_resize, Smint.Vdi_resize;
     `vdi_introduce, Smint.Vdi_introduce;
     `vdi_mirror, Smint.Vdi_mirror;
+    `vdi_enable_cbt, Smint.Vdi_configure_cbt;
+    `vdi_disable_cbt, Smint.Vdi_configure_cbt;
     `update, Smint.Sr_update;
     (* We fake clone ourselves *)
     `vdi_snapshot, Smint.Vdi_snapshot ]

ocaml/xapi/xapi_vdi.ml

@@ -41,6 +41,7 @@ let check_sm_feature_error (op:API.vdi_operations) sm_features sr =
   | `generate_config -> Some Vdi_generate_config
   | `clone -> Some Vdi_clone
   | `mirror -> Some Vdi_mirror
+  | `enable_cbt | `disable_cbt -> Some Vdi_configure_cbt
   ) in
   match required_sm_feature with
   | None -> None
@@ -125,7 +126,7 @@ let check_operation_error ~__context ?(sr_records=[]) ?(pbd_records=[]) ?(vbd_re
          			   VDI.clone (if the VM is suspended we have to have the 'allow_clone_suspended_vm'' flag)
          			   VDI.snapshot; VDI.resize_online; 'blocked' (CP-831) *)
       let operation_can_be_performed_live = match op with
-        | `snapshot | `resize_online | `blocked | `clone | `mirror -> true
+        | `snapshot | `resize_online | `blocked | `clone | `mirror | `enable_cbt | `disable_cbt -> true
         | _ -> false in
 
       let operation_can_be_performed_with_ro_attach =
@@ -199,6 +200,14 @@ let check_operation_error ~__context ?(sr_records=[]) ?(pbd_records=[]) ?(vbd_re
           if List.mem record.Db_actions.vDI_type [ `ha_statefile; `redo_log ]
           then Some (Api_errors.operation_not_allowed, ["VDI containing HA statefile or redo log cannot be copied (check the VDI's allowed operations)."])
           else None
+        | (`enable_cbt | `disable_cbt) ->
+          if record.Db_actions.vDI_is_a_snapshot
+          then Some (Api_errors.operation_not_allowed, ["VDI is a snapshot: " ^ _ref])
+          else if record.Db_actions.vDI_type <> `user
+          then Some (Api_errors.vdi_incompatible_type, [ _ref; Record_util.vdi_type_to_string record.Db_actions.vDI_type ])
+          else if record.Db_actions.vDI_on_boot = `reset
+          then Some (Api_errors.vdi_on_boot_mode_incompatible_with_operation, [])
+          else None
         | `mirror | `clone | `generate_config | `scan | `force_unlock | `blocked | `update -> None
       )