CA-230464: Improve error message when not enough memory for PVS cache (xapi-project#2848)

Signed-off-by: Frederico Mazzone <[email protected]>

Author: Frezzle

ocaml/idl/api_messages.ml

@@ -96,6 +96,7 @@ let v6_license_server_version_obsolete = addMessage "LICENSE_SERVER_VERSION_OBSO
 let pvs_proxy_no_cache_sr_available = addMessage "PVS_PROXY_NO_CACHE_SR_AVAILABLE" 3L (* No cache storage available for pvs site on the host *)
 let pvs_proxy_setup_failed = addMessage "PVS_PROXY_SETUP_FAILED" 3L (* Setting up pvs proxy rules or pvs proxy daemon initialisation failed internally *)
 let pvs_proxy_no_server_available = addMessage "PVS_PROXY_NO_SERVER_AVAILABLE" 3L (* No pvs server available for pvs site on host *)
+let pvs_proxy_sr_out_of_space = addMessage "PVS_PROXY_SR_OUT_OF_SPACE" 3L (* PVS cache storage size exceeds available space on SR *)
 
 (* VMPP message types *)
 let vmpp_snapshot_lock_failed = addMessage "VMPP_SNAPSHOT_LOCK_FAILED" 3L (*'The snapshot phase is already executing for this protection policy. Please try again later'*)

ocaml/xapi/pvs_proxy_control.ml

@@ -249,6 +249,20 @@ let start_proxy ~__context vif proxy =
       | Api_errors.Server_error (code, args) when
           code = Api_errors.openvswitch_not_active ->
         "Host is not using openvswitch"
+      | Api_errors.Server_error ("SR_BACKEND_FAILURE_44", _)
+      | Api_errors.Server_error ("SR_BACKEND_FAILURE_79", _) ->
+        let proxy_uuid = Db.PVS_proxy.get_uuid ~__context ~self:proxy in
+        let body = Printf.sprintf
+          "Unable to setup PVS-proxy %s for VIF %s and PVS-site %s: \
+           PVS cache size for host %s exceeds SR available space."
+          proxy_uuid (Db.VIF.get_uuid ~__context ~self:vif)
+          (Db.PVS_site.get_name_label ~__context ~self:(Db.PVS_proxy.get_site ~__context ~self:proxy))
+          (Db.Host.get_name_label ~__context ~self:(Helpers.get_localhost ~__context)) in
+        let (name, priority) = Api_messages.pvs_proxy_sr_out_of_space in
+        Helpers.call_api_functions ~__context (fun rpc session_id ->
+            ignore(Client.Client.Message.create
+              ~rpc ~session_id ~name  ~priority ~cls:`PVS_proxy ~obj_uuid:proxy_uuid  ~body));
+        "PVS cache size exceeds SR available space"
       | _ -> Printf.sprintf "unknown error (%s)" (Printexc.to_string e)
     in
     State.mark_proxy ~__context site vif proxy State.Failed;