Commit 88d2d5f
committed
Honor existing Origin header when using WebSockets, otherwise use secured scheme for wss, close AsyncHttpClient#1448
Motivation:
When performing initial WebSocket HTTP request, we force Origin header.
This is wrong, as Origin might use a different domain than WebSocket
url.
Also, when computing default Origin, it would make sense to use a
secure scheme when using secured sockets.
Modifications:
* Don’t override existing Origin header
* Use https for wss
Result:
It’s now possible to set Origin on a different domain. Better default1 parent 3cc4a95 commit 88d2d5f
File tree
1 file changed
+6
-1
lines changed- client/src/main/java/org/asynchttpclient/netty/request
1 file changed
+6
-1
lines changedLines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
197 | | - | |
198 | 197 | | |
199 | 198 | | |
200 | 199 | | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
201 | 206 | | |
202 | 207 | | |
203 | 208 | | |
| |||
0 commit comments