Add PIF.set_property

We'll add some constraints to this in the next patches.

Signed-off-by: Rob Hoes <[email protected]>

Author: robhoes

ocaml/idl/datamodel.ml

@@ -4674,14 +4674,26 @@ let pif_db_forget = call
   ~allowed_roles:_R_POOL_OP
   ()
 
+let pif_set_property = call
+	~name:"set_property"
+	~doc:"Set the value of a property of the PIF"
+	~params:[
+		Ref _pif, "self", "The PIF";
+		String, "name", "The property name";
+		String, "value", "The property value";
+	]
+	~lifecycle:[Published, rel_augusta, ""]
+	~allowed_roles:_R_POOL_OP
+	()
+
 let pif = 
     create_obj ~in_db:true ~in_product_since:rel_rio ~in_oss_since:oss_since_303 ~internal_deprecated_since:None ~persist:PersistEverything ~gen_constructor_destructor:false ~name:_pif ~descr:"A physical network interface (note separate VLANs are represented as several PIFs)"
       ~gen_events:true
       ~doccomments:[] 
       ~messages_default_allowed_roles:_R_POOL_OP
       ~messages:[pif_create_VLAN; pif_destroy; pif_reconfigure_ip; pif_reconfigure_ipv6; pif_set_primary_address_type; pif_scan; pif_introduce; pif_forget;
 		pif_unplug; pif_plug; pif_pool_introduce;
-		pif_db_introduce; pif_db_forget
+		pif_db_introduce; pif_db_forget; pif_set_property
 		] ~contents:
       [ uid _pif;
 	(* qualifier changed RW -> StaticRO in Miami *)

ocaml/xapi/message_forwarding.ml

@@ -2902,6 +2902,12 @@ module Forward = functor(Local: Custom_actions.CUSTOM_ACTIONS) -> struct
 			do_op_on ~local_fn ~__context ~host:(Db.PIF.get_host ~__context ~self)
 				(fun session_id rpc -> Client.PIF.set_primary_address_type rpc session_id self primary_address_type)
 
+		let set_property ~__context ~self ~name ~value =
+			info "PIF.set_property: PIF = '%s'; name = '%s'; value = '%s'" (pif_uuid ~__context self) name value;
+			let host = Db.PIF.get_host ~__context ~self in
+			let local_fn = Local.PIF.set_property ~self ~name ~value in
+			do_op_on ~local_fn ~__context ~host (fun session_id rpc -> Client.PIF.set_property rpc session_id self name value)
+
 		let scan ~__context ~host =
 			info "PIF.scan: host = '%s'" (host_uuid ~__context host);
 			let local_fn = Local.PIF.scan ~host in

ocaml/xapi/xapi_pif.ml

@@ -649,6 +649,15 @@ let set_primary_address_type ~__context ~self ~primary_address_type =
 	Db.PIF.set_primary_address_type ~__context ~self ~value:primary_address_type;
 	Monitor_dbcalls.clear_cache_for_pif ~pif_name:(Db.PIF.get_device ~__context ~self)
 
+let set_property ~__context ~self ~name ~value =
+	(* Remove the existing property with this name, then add the new value. *)
+	let properties = List.filter
+		(fun (property_name, _) -> property_name <> name)
+		(Db.PIF.get_properties ~__context ~self)
+	in
+	let properties = (name, value) :: properties in
+	Db.PIF.set_properties ~__context ~self ~value:properties
+
 let rec unplug ~__context ~self =
 	assert_pif_is_managed ~__context ~self;
 	assert_no_protection_enabled ~__context ~self;

ocaml/xapi/xapi_pif.mli

@@ -127,7 +127,15 @@ val set_primary_address_type :
   __context:Context.t ->
   self:API.ref_PIF ->
   primary_address_type:[`IPv4 | `IPv6 ] -> unit
-  
+
+(** Set a property on a PIF *)
+val set_property :
+  __context:Context.t ->
+  self:API.ref_PIF ->
+  name:string ->
+  value:string ->
+  unit
+
 (** Attempt to bring down the PIF: disconnect the underlying network interface from
  *  its bridge and disable the interface. *)
 val unplug : __context:Context.t -> self:API.ref_PIF -> unit