Remove redundant check for allowed VGPU type

The call to assert_capacity_exists_for_VGPU_type will make this call. Note that
assert_capacity_exists_for_VGPU_type returns either VGPU_TYPE_NOT_ALLOWED or
PGPU_INSUFFICIENT_CAPACITY_FOR_VGPU but we are currently ignoring this and
raising VM_REQUIRES_VGPU if the VGPU cannot be allocated on any PGPU on the
host.

Signed-off-by: Si Beaumont <[email protected]>

Author: simonjbeaumont

ocaml/xapi/vgpuops.ml

@@ -115,10 +115,9 @@ let create_virtual_vgpu ~__context vm vgpu =
 	let rec allocate_vgpu vgpu_type = function
 		| [] -> None
 		| pgpu :: remaining_pgpus ->
-			let open Xapi_pgpu_helpers in
 			try
-				assert_VGPU_type_allowed ~__context ~self:pgpu ~vgpu_type;
-				assert_capacity_exists_for_VGPU_type ~__context ~self:pgpu ~vgpu_type;
+				Xapi_pgpu_helpers.assert_capacity_exists_for_VGPU_type
+					~__context ~self:pgpu ~vgpu_type;
 				Some pgpu
 			with _ -> allocate_vgpu vgpu_type remaining_pgpus
 	in