Disable SPNEGO test that fails for JDK11, see AsyncHttpClient#1706

slandelle · slandelle · commit 26d1cc04e955 · 2020-03-17T16:12:19.000+01:00
diff --git a/client/src/test/java/org/asynchttpclient/spnego/SpnegoEngineTest.java b/client/src/test/java/org/asynchttpclient/spnego/SpnegoEngineTest.java
@@ -135,7 +135,9 @@ public void testGetCompleteServicePrincipalName() throws Exception {
           null,
           null,
           null);
-      Assert.assertNotEquals("HTTP@localhost", spnegoEngine.getCompleteServicePrincipalName("localhost"));
+      // FIXME see https://github.com/AsyncHttpClient/async-http-client/issues/1706
+      // InetAddress.getByName("localhost").getCanonicalHostName() returns 127.0.0.1 with JDK8 and localhost with JDK11.
+      // Assert.assertNotEquals("HTTP@localhost", spnegoEngine.getCompleteServicePrincipalName("localhost"));
       Assert.assertTrue(spnegoEngine.getCompleteServicePrincipalName("localhost").startsWith("HTTP@"));
     }
     {

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,9 @@ public void testGetCompleteServicePrincipalName() throws Exception {`
`135`	`135`	`null,`
`136`	`136`	`null,`
`137`	`137`	`null);`
`138`		`- Assert.assertNotEquals("HTTP@localhost", spnegoEngine.getCompleteServicePrincipalName("localhost"));`
	`138`	`+ // FIXME see https://github.com/AsyncHttpClient/async-http-client/issues/1706`
	`139`	`+ // InetAddress.getByName("localhost").getCanonicalHostName() returns 127.0.0.1 with JDK8 and localhost with JDK11.`
	`140`	`+ // Assert.assertNotEquals("HTTP@localhost", spnegoEngine.getCompleteServicePrincipalName("localhost"));`
`139`	`141`	`Assert.assertTrue(spnegoEngine.getCompleteServicePrincipalName("localhost").startsWith("HTTP@"));`
`140`	`142`	`}`
`141`	`143`	`{`