CA-285213 add error logging for Network_interface

This adds logging for all errors passing the network interface.

Signed-off-by: Christian Lindig <[email protected]>

Author: lindig

network/network_interface.ml

@@ -14,6 +14,9 @@
 open Rpc
 open Idl
 
+module D = Debug.Make(struct let name = "network_interface" end)
+open D
+
 (** {2 Helper functions} *)
 
 let service_name = "networkd"
@@ -224,13 +227,31 @@ type errors =
 
 exception Network_error of errors
 
-let err = Error.{
-    def = errors;
-    raiser = (function | e -> raise (Network_error e));
-    matcher = (function
-        | Network_error e -> Some e
-        | e -> Some (Internal_error (Printexc.to_string e)))
-  }
+let () = (* register printer *)
+  let sprintf = Printf.sprintf in
+  let string_of_error e =
+    Rpcmarshal.marshal errors.Rpc.Types.ty e |> Rpc.to_string in
+  let printer = function
+    | Network_error e ->
+        Some (sprintf "Network_interface.Network_error(%s)" (string_of_error e))
+    | _ -> None in
+  Printexc.register_printer printer
+
+let err = Error.
+    { def = errors
+    ; raiser = (fun e ->
+      log_backtrace ();
+      let exn = Network_error e in
+      error "%s (%s)" (Printexc.to_string exn) __LOC__;
+      raise exn)
+    ; matcher = (function
+      | Network_error e as exn ->
+          error "%s (%s)" (Printexc.to_string exn) __LOC__;
+            Some e
+      | exn ->
+          error "%s (%s)" (Printexc.to_string exn) __LOC__;
+            Some (Internal_error (Printexc.to_string exn)))
+    }
 
 (** {2 API functions} *)