Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: xapi-project/xcp-networkd
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: xapi-project/xcp-networkd
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.56.0-lcm
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 1 file changed
  • 1 contributor

Commits on Mar 1, 2021

  1. CA-351826 recognise link/infiniband MAC address 

    xcp-networkd fails to recognise the MAC address of an infiniband NIC
because it only looks for link/ether and misses link/infiniband. If the
former fails, look for link/infiniband, too.

This code could be made more general by using regular expressions for
search rather than strings. However, this would create more changes
which could complicate backports.

Signed-off-by: Christian Lindig <[email protected]>
    @lindig
    lindig committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    4c77f7a View commit details
    Browse the repository at this point in the history

  2. CA-351826 fail if we can't find MAC address of interface 

    Raise an internal error as this is unexpected and there is no good way
to recover.

Signed-off-by: Christian Lindig <[email protected]>
    @lindig
    lindig committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    8458086 View commit details
    Browse the repository at this point in the history

  3. CA-351826 ensure PIF is an ethernet device 

    list() scans for network devices. Since we only knowo how to handle
ethernet devices, check the type of the device and ignore non-ethernet
devices. This should in particular skip over Infiniband devices.

Signed-off-by: Christian Lindig <[email protected]>
    @lindig
    lindig committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    9f4a0b2 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #188 from lindig/CA-351826-stockholm 

    CA-351826 stockholm backport - ignore non-ethernet PIFs
    @lindig
    lindig authored Mar 1, 2021
    Configuration menu
    Copy the full SHA
    c29cd44 View commit details
    Browse the repository at this point in the history
Loading