CP-10203: XenAPI: api call for RDP on/off request

Update code to address the review comments.

Signed-off-by: Hui Zhang <[email protected]>

Author: huizh

ocaml/xapi/xapi_vm.ml

@@ -718,7 +718,13 @@ let beg_rdp ~__context ~vm ~enabled =
 		if is_feature_ts_on ~xs ~domid ~vm
 		then
 			let control_ts = if enabled then "1" else "0" in
+			(*
 			xs.Xenstore.Xs.write (control_path ~xs ~domid "ts") control_ts
+			*)
+			(*
+			set_xenstore_data ~__context ~self:vm ~value:["control/ts",control_ts]
+			*)
+			Xapi_xenops.beg_rdp ~__context ~self:vm enabled
 		else raise (Api_errors.Server_error (Api_errors.vm_lacks_feature_ts, [ Ref.string_of vm ])))
 
 let beg_rdp_on ~__context ~vm =

ocaml/xapi/xapi_vm_lifecycle.ml

@@ -64,6 +64,8 @@ let allowed_power_states ~__context ~vmr ~(op:API.vm_operations) =
 	| `send_trigger
 	| `snapshot_with_quiesce
 	| `suspend
+	| `beg_rdp_on
+	| `beg_rdp_off
 	                                -> [`Running]
 	| `changing_dynamic_range
 	                                -> [`Halted; `Running]
@@ -80,8 +82,6 @@ let allowed_power_states ~__context ~vmr ~(op:API.vm_operations) =
 	| `get_boot_record
 	| `shutdown
 	| `hard_shutdown
-	| `beg_rdp_on
-	| `beg_rdp_off
 	                                -> [`Paused; `Suspended; `Running]
 	| `assert_operation_valid
 	| `metadata_export

ocaml/xapi/xapi_xenops.ml

@@ -1882,6 +1882,19 @@ let unpause ~__context ~self =
 			check_power_state ~__context ~self ~expected:`Running
 		)
 
+let beg_rdp ~__context ~self enabled =
+	let queue_name = queue_of_vm ~__context ~self in
+	transform_xenops_exn ~__context queue_name
+		(fun () ->
+			let id = id_of_vm ~__context ~self in
+			debug "xenops: VM.beg_rdp %s %b" id enabled;
+			let dbg = Context.string_of_task __context in
+			let module Client = (val make_client queue_name : XENOPS) in
+			Client.VM.beg_rdp dbg id enabled |> sync_with_task __context queue_name;
+			Events_from_xenopsd.wait queue_name dbg id ();
+			check_power_state ~__context ~self ~expected:`Running
+		)
+
 let set_xenstore_data ~__context ~self xsdata =
 	let queue_name = queue_of_vm ~__context ~self in
 	transform_xenops_exn ~__context queue_name