Move the --offline argument definition to Xenvm_common

Offline mode will be supported by multiple commands, not just lvchange.

Signed-off-by: David Scott <[email protected]>

Author: djs55

xenvm/lvchange.ml

@@ -170,15 +170,11 @@ let del_tag_arg =
   let doc = "Remove the given tag from the LV" in
   Arg.(value & opt (some string) None & info ["deltag"] ~docv:"DELTAG" ~doc)
 
-let offline_arg =
-  let doc = "Assume xenvmd is offline and read metadata from the disk" in
-  Arg.(value & flag & info [ "offline" ] ~docv:"OFFLINE" ~doc)
- 
 let lvchange_cmd =
   let doc = "Change the attributes of a logical volume" in
   let man = [
     `S "DESCRIPTION";
     `P "lvchange allows you to change the attributes of a logical volume including making them known to the kernel ready for use."
   ] in
-  Term.(pure lvchange $ Xenvm_common.copts_t $ Xenvm_common.name_arg $ Xenvm_common.physical_device_arg $ action_arg $ perm_arg $ refresh_arg $ add_tag_arg $ del_tag_arg $ offline_arg),
+  Term.(pure lvchange $ Xenvm_common.copts_t $ Xenvm_common.name_arg $ Xenvm_common.physical_device_arg $ action_arg $ perm_arg $ refresh_arg $ add_tag_arg $ del_tag_arg $ Xenvm_common.offline_arg),
   Term.info "lvchange" ~sdocs:"COMMON OPTIONS" ~doc ~man

xenvm/xenvm_common.ml

@@ -493,3 +493,8 @@ let action_arg =
 Activation  of a logical volume creates a symbolic link /dev/VolumeGroupName/LogicalVolumeName pointing to the device node.  This link is removed on deactivation.  All software and scripts should access the device through this symbolic link and present this as the name of the device.  The location and name of the underlying device node may depend on the  distribution and configuration (e.g. udev) and might change from release to release." in
   let a = Arg.(value & opt (some char) None & info ["a"] ~docv:"ACTIVATE" ~doc) in
   Term.(pure parse_action $ a)
+
+let offline_arg =
+  let doc = "Assume xenvmd is offline and read metadata from the disk"
+  in
+  Arg.(value & flag & info [ "offline" ] ~docv:"OFFLINE" ~doc)