🚨 made analyzer happy

analysis_options.yaml

@@ -8,4 +8,5 @@ language:
 linter:
   rules:
     one_member_abstracts: false
+    only_throw_errors: false
     public_member_api_docs: false

packages/clean_framework/lib/src/feature_state/feature_widget.dart

@@ -1,10 +1,9 @@
+import 'package:clean_framework/src/feature_state/feature.dart';
+import 'package:clean_framework/src/feature_state/feature_mapper.dart';
+import 'package:clean_framework/src/feature_state/feature_state_provider.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';
 
-import 'feature.dart';
-import 'feature_mapper.dart';
-import 'feature_state_provider.dart';
-
 /// For each feature entry point, a FeatureWidget instance is used to control
 /// the visibility and behavior of the children. One FeatureWidget could have
 /// many UI widgets, one per each state.
@@ -19,14 +18,13 @@ import 'feature_state_provider.dart';
 /// current state for the given Feature, and use it as part of the [builder]
 /// method.
 abstract class FeatureWidget<S> extends ConsumerStatefulWidget {
-  final FeatureStateProvider<S, FeatureMapper<S>> provider;
-  final Feature feature;
-
-  FeatureWidget({
-    Key? key,
+  const FeatureWidget({
+    super.key,
     required this.provider,
     required this.feature,
-  }) : super(key: key);
+  });
+  final FeatureStateProvider<S, FeatureMapper<S>> provider;
+  final Feature feature;
 
   /// The override of this method should return the proper widget depending
   /// on the currentState value. A common pattern is to have states that
@@ -54,7 +52,8 @@ class _FeatureWidgetState<S> extends ConsumerState<FeatureWidget<S>> {
     final mapper = ref.read(widget.provider.featuresMap);
     final currentState = mapper.getStateFor(widget.feature);
 
-    //TODO THIS SHOULDN'T BE NEEDED, FIGURE OUT WHY THE REBUILD DOESN'T HAPPEN
+    // TODO(sarbagyastha): THIS SHOULDN'T BE NEEDED,
+    // FIGURE OUT WHY THE REBUILD DOESN'T HAPPEN
     ref.listen(widget.provider(), (_, __) => setState(() {}));
 
     return widget.builder(context, currentState);

packages/clean_framework/lib/src/open_feature/open_feature.dart

@@ -1,12 +1,12 @@
 // coverage:ignore-file
 library open_feature;
 
-import 'src/core/feature_client.dart';
-import 'src/evaluation_context/evaluation_context.dart';
-import 'src/hook/hook.dart';
-import 'src/open_feature_client.dart';
-import 'src/provider/feature_provider.dart';
-import 'src/provider/no_op_feature_provider.dart';
+import 'package:clean_framework/src/open_feature/src/core/feature_client.dart';
+import 'package:clean_framework/src/open_feature/src/evaluation_context/evaluation_context.dart';
+import 'package:clean_framework/src/open_feature/src/hook/hook.dart';
+import 'package:clean_framework/src/open_feature/src/open_feature_client.dart';
+import 'package:clean_framework/src/open_feature/src/provider/feature_provider.dart';
+import 'package:clean_framework/src/open_feature/src/provider/no_op_feature_provider.dart';
 
 export 'src/core/enums.dart';
 export 'src/core/feature_client.dart';
@@ -30,6 +30,7 @@ class OpenFeature {
 
   static OpenFeature? _instance;
 
+  // ignore: prefer_constructors_over_static_methods
   static OpenFeature get instance {
     return _instance ??= OpenFeature._();
   }

packages/clean_framework/lib/src/open_feature/src/core/enums/error_code.dart

@@ -1,5 +1,7 @@
 // coverage:ignore-file
 
+import 'package:clean_framework/clean_framework.dart';
+
 /// Different error codes that can be returned by the [FeatureProvider].
 enum ErrorCode {
   /// Provider is not in ready state.

packages/clean_framework/lib/src/open_feature/src/core/feature_client.dart

@@ -1,5 +1,5 @@
-import 'flag_evaluation_lifecycle.dart';
-import 'features.dart';
+import 'package:clean_framework/src/open_feature/src/core/features.dart';
+import 'package:clean_framework/src/open_feature/src/core/flag_evaluation_lifecycle.dart';
 
 abstract class FeatureClient extends Features
     implements FlagEvaluationLifecycle {}

packages/clean_framework/lib/src/open_feature/src/core/features.dart

@@ -1,7 +1,7 @@
-import '../evaluation_context/evaluation_context.dart';
-import '../flag_evaluation/flag_evaluation_details.dart';
-import '../flag_evaluation/flag_evaluation_options.dart';
-import 'enums.dart';
+import 'package:clean_framework/src/open_feature/src/core/enums.dart';
+import 'package:clean_framework/src/open_feature/src/evaluation_context/evaluation_context.dart';
+import 'package:clean_framework/src/open_feature/src/flag_evaluation/flag_evaluation_details.dart';
+import 'package:clean_framework/src/open_feature/src/flag_evaluation/flag_evaluation_options.dart';
 
 abstract class Features {
   Future<FlagEvaluationDetails<bool>> getBooleanDetails({

packages/clean_framework/lib/src/open_feature/src/core/flag_evaluation_lifecycle.dart

@@ -1,4 +1,4 @@
-import '../hook/hook.dart';
+import 'package:clean_framework/src/open_feature/src/hook/hook.dart';
 
 abstract class FlagEvaluationLifecycle {
   List<Hook> get hooks;

packages/clean_framework/lib/src/open_feature/src/core/resolution_details.dart

@@ -1,4 +1,4 @@
-import 'enums.dart';
+import 'package:clean_framework/src/open_feature/src/core/enums.dart';
 
 class ResolutionDetails<T> {
   ResolutionDetails({

packages/clean_framework/lib/src/open_feature/src/evaluation_context/context_transformation_mixin.dart

@@ -1,7 +1,7 @@
 import 'dart:async';
 
-import '../provider/feature_provider.dart';
-import 'evaluation_context.dart';
+import 'package:clean_framework/src/open_feature/src/evaluation_context/evaluation_context.dart';
+import 'package:clean_framework/src/open_feature/src/provider/feature_provider.dart';
 
 mixin ContextTransformationMixin on FeatureProvider {
   FutureOr<EvaluationContext> transformContext(EvaluationContext context);

packages/clean_framework/lib/src/open_feature/src/exceptions/open_feature_exception.dart

@@ -1,6 +1,6 @@
 // coverage:ignore-file
 
-import '../core/enums/error_code.dart';
+import 'package:clean_framework/src/open_feature/src/core/enums/error_code.dart';
 
 export '../core/enums/error_code.dart';
 export 'src/flag_not_found_exception.dart';

packages/clean_framework/lib/src/open_feature/src/exceptions/src/flag_not_found_exception.dart

@@ -1,6 +1,6 @@
 // coverage:ignore-file
 
-import '../open_feature_exception.dart';
+import 'package:clean_framework/src/open_feature/src/exceptions/open_feature_exception.dart';
 
 class FlagNotFoundException extends OpenFeatureException {
   FlagNotFoundException(super.message) : super(code: ErrorCode.flagNotFound);

packages/clean_framework/lib/src/open_feature/src/exceptions/src/parse_exception.dart

@@ -1,6 +1,6 @@
 // coverage:ignore-file
 
-import '../open_feature_exception.dart';
+import 'package:clean_framework/src/open_feature/src/exceptions/open_feature_exception.dart';
 
 class ParseException extends OpenFeatureException {
   ParseException(super.message) : super(code: ErrorCode.flagNotFound);

packages/clean_framework/lib/src/open_feature/src/exceptions/src/type_mismatch_exception.dart

@@ -1,6 +1,6 @@
 // coverage:ignore-file
 
-import '../open_feature_exception.dart';
+import 'package:clean_framework/src/open_feature/src/exceptions/open_feature_exception.dart';
 
 class TypeMismatchException extends OpenFeatureException {
   TypeMismatchException(super.message) : super(code: ErrorCode.typeMismatch);

packages/clean_framework/lib/src/open_feature/src/flag_evaluation/flag_evaluation_details.dart

@@ -1,4 +1,4 @@
-import '../core/enums.dart';
+import 'package:clean_framework/src/open_feature/src/core/enums.dart';
 
 class FlagEvaluationDetails<T extends Object> {
   FlagEvaluationDetails({

packages/clean_framework/lib/src/open_feature/src/flag_evaluation/flag_evaluation_options.dart

@@ -1,4 +1,4 @@
-import '../hook/hook.dart';
+import 'package:clean_framework/src/open_feature/src/hook/hook.dart';
 
 class FlagEvaluationOptions {
   const FlagEvaluationOptions({

packages/clean_framework/lib/src/open_feature/src/hook/hook.dart

@@ -2,10 +2,10 @@
 
 import 'dart:async';
 
-import '../evaluation_context/evaluation_context.dart';
-import '../flag_evaluation/flag_evaluation_details.dart';
-import 'hook_context.dart';
-import 'hook_hints.dart';
+import 'package:clean_framework/src/open_feature/src/evaluation_context/evaluation_context.dart';
+import 'package:clean_framework/src/open_feature/src/flag_evaluation/flag_evaluation_details.dart';
+import 'package:clean_framework/src/open_feature/src/hook/hook_context.dart';
+import 'package:clean_framework/src/open_feature/src/hook/hook_hints.dart';
 
 export 'hook_context.dart';
 export 'hook_hints.dart';

packages/clean_framework/lib/src/open_feature/src/hook/hook_context.dart

@@ -1,9 +1,9 @@
 // coverage:ignore-file
 
-import '../core/enums/flag_value_type.dart';
-import '../core/feature_client.dart';
-import '../evaluation_context/evaluation_context.dart';
-import '../provider/feature_provider.dart';
+import 'package:clean_framework/src/open_feature/src/core/enums/flag_value_type.dart';
+import 'package:clean_framework/src/open_feature/src/core/feature_client.dart';
+import 'package:clean_framework/src/open_feature/src/evaluation_context/evaluation_context.dart';
+import 'package:clean_framework/src/open_feature/src/provider/feature_provider.dart';
 
 class HookContext<T extends Object> {
   HookContext({

packages/clean_framework/lib/src/open_feature/src/open_feature_client.dart

@@ -1,7 +1,7 @@
 // coverage:ignore-file
 
-import '../open_feature.dart';
-import 'flag_evaluation/flag_evaluation_details.dart';
+import 'package:clean_framework/src/open_feature/open_feature.dart';
+import 'package:clean_framework/src/open_feature/src/flag_evaluation/flag_evaluation_details.dart';
 
 typedef FeatureProviderResolver<T extends Object> = Future<ResolutionDetails<T>>
     Function({

packages/clean_framework/lib/src/open_feature/src/provider/feature_provider.dart

@@ -1,6 +1,6 @@
-import '../core/resolution_details.dart';
-import '../evaluation_context/evaluation_context.dart';
-import '../flag_evaluation/flag_evaluation_options.dart';
+import 'package:clean_framework/src/open_feature/src/core/resolution_details.dart';
+import 'package:clean_framework/src/open_feature/src/evaluation_context/evaluation_context.dart';
+import 'package:clean_framework/src/open_feature/src/flag_evaluation/flag_evaluation_options.dart';
 
 abstract class FeatureProvider {
   String get name;

packages/clean_framework/lib/src/open_feature/src/provider/no_op_feature_provider.dart

@@ -1,10 +1,10 @@
 // coverage:ignore-file
 
-import '../core/enums/reason.dart';
-import '../core/resolution_details.dart';
-import '../evaluation_context/evaluation_context.dart';
-import '../flag_evaluation/flag_evaluation_options.dart';
-import 'feature_provider.dart';
+import 'package:clean_framework/src/open_feature/src/core/enums/reason.dart';
+import 'package:clean_framework/src/open_feature/src/core/resolution_details.dart';
+import 'package:clean_framework/src/open_feature/src/evaluation_context/evaluation_context.dart';
+import 'package:clean_framework/src/open_feature/src/flag_evaluation/flag_evaluation_options.dart';
+import 'package:clean_framework/src/open_feature/src/provider/feature_provider.dart';
 
 class NoOpFeatureProvider implements FeatureProvider {
   const NoOpFeatureProvider();

packages/clean_framework/lib/src/providers/bridge_gateway_provider.dart

@@ -1,15 +1,14 @@
 import 'package:clean_framework/clean_framework.dart';
+import 'package:clean_framework/src/providers/gateway.dart';
 import 'package:clean_framework/src/providers/overridable_provider.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';
 
-import 'gateway.dart';
-
 class BridgeGatewayProvider<G extends BridgeGateway>
     implements OverridableProvider<G> {
-  final Provider<G> _provider;
-  final G Function(Ref) create;
 
   BridgeGatewayProvider(this.create) : _provider = Provider<G>(create);
+  final Provider<G> _provider;
+  final G Function(Ref) create;
 
   @override
   Override overrideWith(G gateway) => _provider.overrideWithValue(gateway);

packages/clean_framework/lib/src/providers/external_interface.dart

@@ -1,10 +1,9 @@
 import 'dart:async';
 
+import 'package:clean_framework/src/providers/gateway.dart';
 import 'package:clean_framework/src/utilities/clean_framework_observer.dart';
 import 'package:either_dart/either.dart';
 
-import 'gateway.dart';
-
 abstract class ExternalInterface<R extends Request, S extends SuccessResponse> {
   ExternalInterface(List<GatewayConnection<Gateway>> gatewayConnections) {
     handleRequest();
@@ -97,7 +96,7 @@ class _RequestCompleter<R extends Request, S extends SuccessResponse> {
 
 class _StreamRequestCompleter<R extends Request, S extends SuccessResponse>
     extends _RequestCompleter<R, S> {
-  _StreamRequestCompleter(R request, this.emitSuccess) : super(request);
+  _StreamRequestCompleter(super.request, this.emitSuccess);
 
   final void Function(S) emitSuccess;
 }

packages/clean_framework/lib/src/providers/external_interface_provider.dart

@@ -5,10 +5,10 @@ import 'package:flutter_riverpod/flutter_riverpod.dart';
 
 class ExternalInterfaceProvider<I extends ExternalInterface>
     implements OverridableProvider<I> {
-  final Provider<I> _provider;
-  final I Function(Ref) create;
 
   ExternalInterfaceProvider(this.create) : _provider = Provider<I>(create);
+  final Provider<I> _provider;
+  final I Function(Ref) create;
 
   @override
   Override overrideWith(I interface) => _provider.overrideWithValue(interface);

packages/clean_framework/lib/src/providers/gateway.dart

@@ -1,32 +1,33 @@
 import 'package:clean_framework/clean_framework_providers.dart';
+import 'package:clean_framework/src/app_providers_container.dart';
 import 'package:clean_framework/src/utilities/clean_framework_observer.dart';
 import 'package:either_dart/either.dart';
 import 'package:equatable/equatable.dart';
 import 'package:meta/meta.dart';
 
-import '../app_providers_container.dart';
-
 abstract class Gateway<O extends Output, R extends Request,
     P extends SuccessResponse, S extends SuccessInput> {
-  late UseCase _useCase;
-
-  late final Transport<R, P> transport;
-
   Gateway({
     ProvidersContext? context,
     UseCaseProvider? provider,
     UseCase? useCase,
-  }) {
-    assert(() {
-      return (context != null && provider != null) || useCase != null;
-    }());
+  }) : assert(
+          () {
+            return (context != null && provider != null) || useCase != null;
+          }(),
+          '',
+        ) {
     _useCase = useCase ?? provider!.getUseCaseFromContext(context!);
     _useCase.subscribe(
       O,
       (O output) async => _processRequest(buildRequest(output)),
     );
   }
 
+  late UseCase _useCase;
+
+  late final Transport<R, P> transport;
+
   S onSuccess(covariant P response);
   FailureInput onFailure(covariant FailureResponse failureResponse);
   R buildRequest(O output);
@@ -48,9 +49,6 @@ abstract class Gateway<O extends Output, R extends Request,
 
 abstract class BridgeGateway<SUBSCRIBER_OUTPUT extends Output,
     PUBLISHER_OUTPUT extends Output, SUBSCRIBER_INPUT extends Input> {
-  late UseCase _subscriberUseCase;
-  late UseCase _publisherUseCase;
-
   BridgeGateway({
     required UseCase subscriberUseCase,
     required UseCase publisherUseCase,
@@ -67,6 +65,8 @@ abstract class BridgeGateway<SUBSCRIBER_OUTPUT extends Output,
       },
     );
   }
+  late final UseCase _subscriberUseCase;
+  late final UseCase _publisherUseCase;
 
   SUBSCRIBER_INPUT onResponse(PUBLISHER_OUTPUT output);
 }
@@ -125,8 +125,8 @@ class TypedFailureResponse<T extends Object> extends FailureResponse {
   const TypedFailureResponse({
     required this.type,
     this.errorData = const {},
-    String message = '',
-  }) : super(message: message);
+    super.message,
+  });
 
   final T type;
   final Map<String, Object?> errorData;

packages/clean_framework/lib/src/providers/gateway_provider.dart

@@ -1,14 +1,13 @@
 import 'package:clean_framework/clean_framework.dart';
+import 'package:clean_framework/src/providers/gateway.dart';
 import 'package:clean_framework/src/providers/overridable_provider.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';
 
-import 'gateway.dart';
-
 class GatewayProvider<G extends Gateway> implements OverridableProvider<G> {
-  final Provider<G> _provider;
-  final G Function(Ref) create;
 
   GatewayProvider(this.create) : _provider = Provider<G>(create);
+  final Provider<G> _provider;
+  final G Function(Ref) create;
 
   @override
   Override overrideWith(G gateway) => _provider.overrideWithValue(gateway);