Add remote channel ip address to read timeout exception, port AsyncHttpClient#538 on master

Author: Stephane Landelle

providers/netty/src/main/java/org/asynchttpclient/providers/netty/future/NettyResponseFuture.java

@@ -34,6 +34,7 @@
 import io.netty.handler.codec.http.HttpHeaders;
 import io.netty.handler.codec.http.HttpResponse;
 
+import java.net.SocketAddress;
 import java.net.URI;
 import java.util.concurrent.CancellationException;
 import java.util.concurrent.CountDownLatch;
@@ -468,6 +469,10 @@ public boolean canRetry() {
         return true;
     }
 
+    public SocketAddress getChannelRemoteAddress() {
+        return channel() != null? channel().remoteAddress(): null;
+    }
+    
     public void setRequest(Request request) {
         this.request = request;
     }

providers/netty/src/main/java/org/asynchttpclient/providers/netty/request/timeout/RequestTimeoutTimerTask.java

@@ -45,8 +45,9 @@ public void run(Timeout timeout) throws Exception {
         }
 
         if (!nettyResponseFuture.isDone() && !nettyResponseFuture.isCancelled()) {
-            expire("Request timeout of " + nettyResponseFuture.getRequestTimeoutInMs() + " ms",
-                    millisTime() - nettyResponseFuture.getStart());
+            long age = millisTime() - nettyResponseFuture.getStart();
+            expire("Request timed out to " + nettyResponseFuture.getChannelRemoteAddress() + " of "
+                    + nettyResponseFuture.getRequestTimeoutInMs() + " ms after " + age + " ms", age);
             nettyResponseFuture.setRequestTimeoutReached();
         }
     }

providers/netty/src/test/java/org/asynchttpclient/providers/netty/NettyPerRequestTimeoutTest.java

@@ -22,7 +22,9 @@ public class NettyPerRequestTimeoutTest extends PerRequestTimeoutTest {
 
     @Override
     protected void checkTimeoutMessage(String message) {
-        assertTrue(message.equals("Request timeout of 100 ms"));
+        assertTrue(message.startsWith("Request timed out"), "error message indicates reason of error");
+        assertTrue(message.contains("127.0.0.1"), "error message contains remote ip address");
+        assertTrue(message.contains("of 100 ms"), "error message contains timeout configuration value");
     }
 
     @Override