fix certificate caching, fixes googleapis#1033 (googleapis#1322)

redcapital · bshaffer · commit 3eea433cec08 · 2017-12-05T19:45:34.000-06:00
diff --git a/src/Google/AccessToken/Verify.php b/src/Google/AccessToken/Verify.php
@@ -178,7 +178,7 @@ private function getFederatedSignOnCerts()
   {
     $certs = null;
     if ($cache = $this->getCache()) {
-      $cacheItem = $cache->getItem('federated_signon_certs_v3', 3600);
+      $cacheItem = $cache->getItem('federated_signon_certs_v3');
       $certs = $cacheItem->get();
     }
 
@@ -189,6 +189,7 @@ private function getFederatedSignOnCerts()
       );
 
       if ($cache) {
+        $cacheItem->expiresAt(new DateTime('+1 hour'));
         $cacheItem->set($certs);
         $cache->save($cacheItem);
       }

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ private function getFederatedSignOnCerts()`
`178`	`178`	`{`
`179`	`179`	`$certs = null;`
`180`	`180`	`if ($cache = $this->getCache()) {`
`181`		`- $cacheItem = $cache->getItem('federated_signon_certs_v3', 3600);`
	`181`	`+ $cacheItem = $cache->getItem('federated_signon_certs_v3');`
`182`	`182`	`$certs = $cacheItem->get();`
`183`	`183`	`}`
`184`	`184`
`@@ -189,6 +189,7 @@ private function getFederatedSignOnCerts()`
`189`	`189`	`);`
`190`	`190`
`191`	`191`	`if ($cache) {`
	`192`	`+ $cacheItem->expiresAt(new DateTime('+1 hour'));`
`192`	`193`	`$cacheItem->set($certs);`
`193`	`194`	`$cache->save($cacheItem);`
`194`	`195`	`}`