Fix AsyncHttpClientCall#responseCallback NPE

Plus minor nits

Author: slandelle

extras/retrofit2/src/main/java/org/asynchttpclient/extras/retrofit/AsyncHttpClientCall.java

@@ -161,7 +161,7 @@ public Call clone() {
 
     protected <T> T handleException(Throwable throwable, Callback responseCallback) {
         try {
-            if (responseCallback == null) {
+            if (responseCallback != null) {
                 responseCallback.onFailure(this, toIOException(throwable));
             }
         } catch (Exception e) {

extras/retrofit2/src/test/java/org/asynchttpclient/extras/retrofit/AsyncHttpClientCallTest.java

@@ -12,17 +12,11 @@
  */
 package org.asynchttpclient.extras.retrofit;
 
+import static org.asynchttpclient.extras.retrofit.AsyncHttpClientCall.*;
+import static org.mockito.Matchers.any;
+import static org.mockito.Mockito.*;
+import static org.testng.Assert.assertTrue;
 import io.netty.handler.codec.http.EmptyHttpHeaders;
-import lombok.extern.slf4j.Slf4j;
-import lombok.val;
-import okhttp3.Request;
-import org.asynchttpclient.AsyncCompletionHandler;
-import org.asynchttpclient.AsyncHttpClient;
-import org.asynchttpclient.BoundRequestBuilder;
-import org.asynchttpclient.Response;
-import org.testng.Assert;
-import org.testng.annotations.DataProvider;
-import org.testng.annotations.Test;
 
 import java.io.IOException;
 import java.util.Arrays;
@@ -32,14 +26,17 @@
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.function.Consumer;
 
-import static org.asynchttpclient.extras.retrofit.AsyncHttpClientCall.runConsumer;
-import static org.asynchttpclient.extras.retrofit.AsyncHttpClientCall.runConsumers;
-import static org.mockito.Matchers.any;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
-import static org.testng.Assert.assertTrue;
+import lombok.val;
+import okhttp3.Request;
+
+import org.asynchttpclient.AsyncCompletionHandler;
+import org.asynchttpclient.AsyncHttpClient;
+import org.asynchttpclient.BoundRequestBuilder;
+import org.asynchttpclient.Response;
+import org.testng.Assert;
+import org.testng.annotations.DataProvider;
+import org.testng.annotations.Test;
 
-@Slf4j
 public class AsyncHttpClientCallTest {
     static final Request REQUEST = new Request.Builder().url("http://www.google.com/").build();
 
@@ -60,7 +57,7 @@ Object[][] dataProviderFirst() {
     }
 
     @Test(dataProvider = "second")
-    void shouldInvokeConsumersOnEachExecution(Consumer<AsyncCompletionHandler> handlerConsumer,
+    void shouldInvokeConsumersOnEachExecution(Consumer<AsyncCompletionHandler<?>> handlerConsumer,
                                               int expectedStarted,
                                               int expectedOk,
                                               int expectedFailed) {
@@ -82,6 +79,7 @@ void shouldInvokeConsumersOnEachExecution(Consumer<AsyncCompletionHandler> handl
         when(httpClient.prepareRequest((org.asynchttpclient.RequestBuilder) any())).thenReturn(brb);
 
         when(httpClient.executeRequest((org.asynchttpclient.Request) any(), any())).then(invocationOnMock -> {
+            @SuppressWarnings("rawtypes")
             val handler = invocationOnMock.getArgumentAt(1, AsyncCompletionHandler.class);
             handlerConsumer.accept(handler);
             return null;
@@ -140,15 +138,13 @@ Object[][] dataProviderSecond() {
         when(response.getStatusText()).thenReturn("OK");
         when(response.getHeaders()).thenReturn(EmptyHttpHeaders.INSTANCE);
 
-        AsyncCompletionHandler x = null;
-
-        Consumer<AsyncCompletionHandler> okConsumer = handler -> {
+        Consumer<AsyncCompletionHandler<?>> okConsumer = handler -> {
             try {
                 handler.onCompleted(response);
             } catch (Exception e) {
             }
         };
-        Consumer<AsyncCompletionHandler> failedConsumer = handler -> handler.onThrowable(new TimeoutException("foo"));
+        Consumer<AsyncCompletionHandler<?>> failedConsumer = handler -> handler.onThrowable(new TimeoutException("foo"));
 
         return new Object[][]{
                 {okConsumer, 1, 1, 0},

extras/retrofit2/src/test/java/org/asynchttpclient/extras/retrofit/TestServices.java

@@ -35,7 +35,6 @@ public static class Contributor implements Serializable {
         @NonNull
         String login;
 
-        @NonNull
         int contributions;
     }