Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: php-webdriver/php-webdriver
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: AtricoSoftware/php-webdriver
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: community
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Mar 5, 2018

  1. Minor tweak to environment variable name. 

    Allow a second attempt to read a bash compatible variable

1. Why is this change necessary?
Current environment variable in ChromeDriver.php uses '.', whilst valid according to the specification, this will not work using a bash shell (probably the most commonly used)

2. How does it address the issue?
'.' replaced with '_'.  This is usable in bash (including cygwin)
Original code still there, only attempts new variable if original does not exist

3. What are the side effects?
None, previous name will still work, new name only used if original name does not exist
    @RobRimmer
    RobRimmer committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    2982d6d View commit details
    Browse the repository at this point in the history
Loading