Protect Meets Core: Fix "0" rendered by conditional render chain (#40882)

nateweller · nateweller · commit 28653ce3676e · 2025-02-03T09:43:48.000-07:00
diff --git a/projects/plugins/protect/src/js/routes/scan/index.jsx b/projects/plugins/protect/src/js/routes/scan/index.jsx
@@ -35,8 +35,8 @@ const ScanPage = () => {
 		currentScanStatus = 'active';
 	}
 
-	const hasActiveThreats = status && status.threats.length;
-	const hasHistory = history && history.threats.length;
+	const hasActiveThreats = status && !! status.threats.length;
+	const hasHistory = history && !! history.threats.length;
 	const showResults = hasActiveThreats || hasHistory;
 
 	// Track view for Protect admin page.

Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,8 @@ const ScanPage = () => {`
`35`	`35`	`currentScanStatus = 'active';`
`36`	`36`	`}`
`37`	`37`
`38`		`- const hasActiveThreats = status && status.threats.length;`
`39`		`- const hasHistory = history && history.threats.length;`
	`38`	`+ const hasActiveThreats = status && !! status.threats.length;`
	`39`	`+ const hasHistory = history && !! history.threats.length;`
`40`	`40`	`const showResults = hasActiveThreats \|\| hasHistory;`
`41`	`41`
`42`	`42`	`// Track view for Protect admin page.`