Skip to content

types(connection): fix return type of withSession() #14690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2024
Merged

types(connection): fix return type of withSession() #14690

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
561a580
test: add type test for Connection.withSession
apparedev Jun 25, 2024
cc63f69
feat: fix return type of Connection.withSession
apparedev Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
feat: fix return type of Connection.withSession
  • Loading branch information
@apparedev
apparedev committed Jun 25, 2024
commit cc63f6955ca4aa7b43b9c6ea880d55bbc01eecb4
2 changes: 1 addition & 1 deletion types/connection.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ declare module 'mongoose' {
/** Watches the entire underlying database for changes. Similar to [`Model.watch()`](/docs/api/model.html#model_Model-watch). */
watch<ResultType extends mongodb.Document = any>(pipeline?: Array<any>, options?: mongodb.ChangeStreamOptions): mongodb.ChangeStream<ResultType>;

withSession<T = any>(executor: (session: ClientSession) => Promise<T>): T;
withSession<T = any>(executor: (session: ClientSession) => Promise<T>): Promise<T>;
}

}