Skip to content

allow mongoose.connection.db to be undefined #14797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2024
Merged

allow mongoose.connection.db to be undefined #14797

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c955b1
allow `mongoose.connection.db` to be undefined
IslandRhythms Aug 8, 2024
7d5c845
Update connect.test.ts
vkarpov15 Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
allow mongoose.connection.db to be undefined
  • Loading branch information
@IslandRhythms
IslandRhythms committed Aug 8, 2024
commit 3c955b1d3518e8f9612667b01a71e06e5b758e4a
1 change: 1 addition & 0 deletions test/types/connect.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ import { expectType } from 'tsd';
expectType<Promise<typeof mongoose>>(connect('mongodb://127.0.0.1:27017/test'));
expectType<Promise<typeof mongoose>>(connect('mongodb://127.0.0.1:27017/test', {}));
expectType<Promise<typeof mongoose>>(connect('mongodb://127.0.0.1:27017/test', { bufferCommands: true }));
expectType<Promise<typeof mongoose>>(connect('mongodb://127.0.0.1:27017/test', { bufferCommands: true }));
4 changes: 2 additions & 2 deletions test/types/connection.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ expectType<Array<string>>(conn.modelNames());
expectType<Promise<void>>(createConnection('mongodb://127.0.0.1:27017/test').close());
expectType<Promise<void>>(createConnection('mongodb://127.0.0.1:27017/test').close(true));

expectType<mongodb.Db>(conn.db);
expectType<mongodb.Db | undefined>(conn.db);

expectType<mongodb.MongoClient>(conn.getClient());
expectType<Connection>(conn.setClient(new mongodb.MongoClient('mongodb://127.0.0.1:27017/test')));
Expand All @@ -65,7 +65,7 @@ expectError(conn.host = 'invalid');
expectError(conn.port = 'invalid');

expectType<Collection>(conn.collection('test'));
expectType<mongodb.Collection>(conn.db.collection('test'));
expectType<mongodb.Collection | undefined>(conn.db?.collection('test'));

expectType<Promise<mongodb.ClientSession>>(conn.startSession());
expectType<Promise<mongodb.ClientSession>>(conn.startSession({ causalConsistency: true }));
Expand Down
2 changes: 1 addition & 1 deletion types/connection.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ declare module 'mongoose' {
readonly config: any;

/** The mongodb.Db instance, set when the connection is opened */
readonly db: mongodb.Db;
readonly db: mongodb.Db | undefined;

/**
* Helper for `createCollection()`. Will explicitly create the given collection
Expand Down