Skip to content

Conversation

@gambtho
Copy link
Contributor

@gambtho gambtho commented Aug 31, 2023

Description

update all dependencies

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?

  • unit tests
  • e2e

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@coveralls
Copy link
Collaborator

coveralls commented Aug 31, 2023

Pull Request Test Coverage Report for Build 6041692148

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 88.924%

Files with Coverage Reduction New Missed Lines %
pkg/controller/common/resource_reconciler.go 12 62.0%
Totals Coverage Status
Change from base Build 6041135770: -0.5%
Covered Lines: 1959
Relevant Lines: 2203

💛 - Coveralls

Copy link
Member

@bfoley13 bfoley13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@OliverMKing OliverMKing merged commit 6542146 into main Sep 1, 2023
@gambtho gambtho deleted the thgamble/depbump2 branch September 6, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants