Skip to content

Commit b03ac09

Browse files
EvgenyAgafonchikovdsgouda
EvgenyAgafonchikov
authored and
dsgouda
committed
Reduced warnings count (#6043)
* Suppress "expected" warnings * Refactored ApiVersion, SubscriptionId params usage * Fixed VMSS related warnings
1 parent ed71a2b commit b03ac09

File tree

7 files changed

+76
-156
lines changed

7 files changed

+76
-156
lines changed

‎specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/azureFirewallFqdnTag.json‎

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,10 @@
4343
"description":"Gets all the Azure Firewall FQDN Tags in a subscription.",
4444
"parameters":[
4545
{
46-
"$ref":"#/parameters/ApiVersionParameter"
46+
"$ref": "./network.json#/parameters/ApiVersionParameter"
4747
},
4848
{
49-
"$ref":"#/parameters/SubscriptionIdParameter"
49+
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
5050
}
5151
],
5252
"responses":{
@@ -120,21 +120,5 @@
120120
},
121121
"description":"Response for ListAzureFirewallFqdnTags API service call."
122122
}
123-
},
124-
"parameters": {
125-
"SubscriptionIdParameter": {
126-
"name": "subscriptionId",
127-
"in": "path",
128-
"required": true,
129-
"type": "string",
130-
"description": "The subscription credentials which uniquely identify the Microsoft Azure subscription. The subscription ID forms part of the URI for every service call."
131-
},
132-
"ApiVersionParameter": {
133-
"name": "api-version",
134-
"in": "query",
135-
"required": true,
136-
"type": "string",
137-
"description": "Client API version."
138-
}
139123
}
140124
}

‎specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/network.json‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -282,6 +282,20 @@
282282
"required": true,
283283
"type": "string",
284284
"description": "Client API version."
285+
},
286+
"ApiVersionVmssParameter": {
287+
"name": "api-version",
288+
"in": "query",
289+
"required": true,
290+
"type": "string",
291+
"enum": [
292+
"2017-03-30"
293+
],
294+
"x-ms-enum": {
295+
"name": "ApiVersion",
296+
"modelAsString": true
297+
},
298+
"description": "Client API version."
285299
}
286300
}
287301
}

‎specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/virtualNetworkTap.json‎

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -301,8 +301,8 @@
301301
}
302302
}
303303
}
304-
},
305-
"definitions": {
304+
},
305+
"definitions": {
306306
"VirtualNetworkTap": {
307307
"properties": {
308308
"properties": {
@@ -374,21 +374,5 @@
374374
},
375375
"description": "Response for ListVirtualNetworkTap API service call."
376376
}
377-
},
378-
"parameters": {
379-
"SubscriptionIdParameter": {
380-
"name": "subscriptionId",
381-
"in": "path",
382-
"required": true,
383-
"type": "string",
384-
"description": "The subscription credentials which uniquely identify the Microsoft Azure subscription. The subscription ID forms part of the URI for every service call."
385-
},
386-
"ApiVersionParameter": {
387-
"name": "api-version",
388-
"in": "query",
389-
"required": true,
390-
"type": "string",
391-
"description": "Client API version."
392-
}
393-
}
377+
}
394378
}

‎specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/vmssNetworkInterface.json‎

Lines changed: 5 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -64,18 +64,7 @@
6464
"description": "The virtual machine index."
6565
},
6666
{
67-
"name": "api-version",
68-
"in": "query",
69-
"required": true,
70-
"type": "string",
71-
"enum": [
72-
"2017-03-30"
73-
],
74-
"x-ms-enum": {
75-
"name": "ApiVersion",
76-
"modelAsString": true
77-
},
78-
"description": "Client API version."
67+
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
7968
},
8069
{
8170
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
@@ -120,18 +109,7 @@
120109
"description": "The name of the virtual machine scale set."
121110
},
122111
{
123-
"name": "api-version",
124-
"in": "query",
125-
"required": true,
126-
"type": "string",
127-
"enum": [
128-
"2017-03-30"
129-
],
130-
"x-ms-enum": {
131-
"name": "ApiVersion",
132-
"modelAsString": true
133-
},
134-
"description": "Client API version."
112+
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
135113
},
136114
{
137115
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
@@ -190,18 +168,7 @@
190168
"description": "The name of the network interface."
191169
},
192170
{
193-
"name": "api-version",
194-
"in": "query",
195-
"required": true,
196-
"type": "string",
197-
"enum": [
198-
"2017-03-30"
199-
],
200-
"x-ms-enum": {
201-
"name": "ApiVersion",
202-
"modelAsString": true
203-
},
204-
"description": "Client API version."
171+
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
205172
},
206173
{
207174
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
@@ -264,18 +231,7 @@
264231
"description": "The name of the network interface."
265232
},
266233
{
267-
"name": "api-version",
268-
"in": "query",
269-
"required": true,
270-
"type": "string",
271-
"enum": [
272-
"2017-03-30"
273-
],
274-
"x-ms-enum": {
275-
"name": "ApiVersion",
276-
"modelAsString": true
277-
},
278-
"description": "Client API version."
234+
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
279235
},
280236
{
281237
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
@@ -348,18 +304,7 @@
348304
"description": "The name of the ip configuration."
349305
},
350306
{
351-
"name": "api-version",
352-
"in": "query",
353-
"required": true,
354-
"type": "string",
355-
"enum": [
356-
"2017-03-30"
357-
],
358-
"x-ms-enum": {
359-
"name": "ApiVersion",
360-
"modelAsString": true
361-
},
362-
"description": "Client API version."
307+
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
363308
},
364309
{
365310
"$ref": "./network.json#/parameters/SubscriptionIdParameter"

‎specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/vmssPublicIpAddress.json‎

Lines changed: 3 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -54,18 +54,7 @@
5454
"description": "The name of the virtual machine scale set."
5555
},
5656
{
57-
"name": "api-version",
58-
"in": "query",
59-
"required": true,
60-
"type": "string",
61-
"enum": [
62-
"2017-03-30"
63-
],
64-
"x-ms-enum": {
65-
"name": "ApiVersion",
66-
"modelAsString": true
67-
},
68-
"description": "Client API version."
57+
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
6958
},
7059
{
7160
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
@@ -128,18 +117,7 @@
128117
"description": "The IP configuration name."
129118
},
130119
{
131-
"name": "api-version",
132-
"in": "query",
133-
"required": true,
134-
"type": "string",
135-
"enum": [
136-
"2017-03-30"
137-
],
138-
"x-ms-enum": {
139-
"name": "ApiVersion",
140-
"modelAsString": true
141-
},
142-
"description": "Client API version."
120+
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
143121
},
144122
{
145123
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
@@ -209,18 +187,7 @@
209187
"description": "The name of the public IP Address."
210188
},
211189
{
212-
"name": "api-version",
213-
"in": "query",
214-
"required": true,
215-
"type": "string",
216-
"enum": [
217-
"2017-03-30"
218-
],
219-
"x-ms-enum": {
220-
"name": "ApiVersion",
221-
"modelAsString": true
222-
},
223-
"description": "Client API version."
190+
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
224191
},
225192
{
226193
"$ref": "./network.json#/parameters/SubscriptionIdParameter"

‎specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/webapplicationfirewall.json‎

Lines changed: 7 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,10 @@
5555
"description": "The name of the resource group."
5656
},
5757
{
58-
"$ref": "#/parameters/SubscriptionIdParameter"
58+
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
5959
},
6060
{
61-
"$ref": "#/parameters/ApiVersionParameter"
61+
"$ref": "./network.json#/parameters/ApiVersionParameter"
6262
}
6363
],
6464
"responses": {
@@ -136,10 +136,10 @@
136136
"description": "The name of the policy."
137137
},
138138
{
139-
"$ref": "#/parameters/SubscriptionIdParameter"
139+
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
140140
},
141141
{
142-
"$ref": "#/parameters/ApiVersionParameter"
142+
"$ref": "./network.json#/parameters/ApiVersionParameter"
143143
}
144144
],
145145
"responses": {
@@ -179,7 +179,7 @@
179179
"description": "The name of the policy."
180180
},
181181
{
182-
"$ref": "#/parameters/SubscriptionIdParameter"
182+
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
183183
},
184184
{
185185
"description": "Policy to be created.",
@@ -237,10 +237,10 @@
237237
"description": "The name of the policy."
238238
},
239239
{
240-
"$ref": "#/parameters/SubscriptionIdParameter"
240+
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
241241
},
242242
{
243-
"$ref": "#/parameters/ApiVersionParameter"
243+
"$ref": "./network.json#/parameters/ApiVersionParameter"
244244
}
245245
],
246246
"responses": {
@@ -533,21 +533,5 @@
533533
}
534534
}
535535
}
536-
},
537-
"parameters": {
538-
"SubscriptionIdParameter": {
539-
"name": "subscriptionId",
540-
"in": "path",
541-
"required": true,
542-
"type": "string",
543-
"description": "The subscription credentials which uniquely identify the Microsoft Azure subscription. The subscription ID forms part of the URI for every service call."
544-
},
545-
"ApiVersionParameter": {
546-
"name": "api-version",
547-
"in": "query",
548-
"required": true,
549-
"type": "string",
550-
"description": "Client API version."
551-
}
552536
}
553537
}

‎specification/network/resource-manager/readme.md‎

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1017,6 +1017,48 @@ directive:
10171017
- suppress: RequiredPropertiesMissingInResourceModel
10181018
from: webapplicationfirewall.json
10191019
reason: name, id and type properties are inherited from the upper level
1020+
- suppress: PostOperationIdContainsUrlVerb
1021+
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/applicationGateways/{applicationGatewayName}/getBackendHealthOnDemand"].post.operationId
1022+
reason: Customized verb is used for API
1023+
- suppress: PostOperationIdContainsUrlVerb
1024+
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualWans/{virtualWANName}/vpnConfiguration"].post.operationId
1025+
reason: Customized verb is used for API
1026+
- suppress: ListInOperationName
1027+
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/applicationGateways/{applicationGatewayName}/backendhealth"].post.operationId
1028+
reason: Customized verb is used for API
1029+
- suppress: ListInOperationName
1030+
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkInterfaces/{networkInterfaceName}/effectiveRouteTable"].post.operationId
1031+
reason: Customized verb is used for API
1032+
- suppress: ListInOperationName
1033+
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkWatchers/{networkWatcherName}/securityGroupView"].post.operationId
1034+
reason: Customized verb is used for API
1035+
- suppress: ListInOperationName
1036+
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkWatchers/{networkWatcherName}/connectionMonitors/{connectionMonitorName}/query"].post.operationId
1037+
reason: Customized verb is used for API
1038+
- suppress: ListInOperationName
1039+
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkWatchers/{networkWatcherName}/networkConfigurationDiagnostic"].post.operationId
1040+
reason: Customized verb is used for API
1041+
- suppress: ListInOperationName
1042+
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworks/{virtualNetworkName}/CheckIPAddressAvailability"].get.operationId
1043+
reason: Customized verb is used for API
1044+
- suppress: ListInOperationName
1045+
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getBgpPeerStatus"].post.operationId
1046+
reason: Customized verb is used for API
1047+
- suppress: ListInOperationName
1048+
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getLearnedRoutes"].post.operationId
1049+
reason: Customized verb is used for API
1050+
- suppress: ListInOperationName
1051+
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getAdvertisedRoutes"].post.operationId
1052+
reason: Customized verb is used for API
1053+
- suppress: ListInOperationName
1054+
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getVpnClientConnectionHealth"].post.operationId
1055+
reason: Customized verb is used for API
1056+
- suppress: ListInOperationName
1057+
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualWans/{virtualWANName}/supportedSecurityProviders"].get.operationId
1058+
reason: Customized verb is used for API
1059+
- suppress: GetInOperationName
1060+
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualWans/{virtualWANName}/supportedSecurityProviders"].get.operationId
1061+
reason: Customized verb is used for API
10201062
```
10211063

10221064
---

0 commit comments

Comments
 (0)