From 990e67dd2440455b0163f05cce65cef344d2d5f2 Mon Sep 17 00:00:00 2001 From: Manchit Gupta Date: Fri, 8 Mar 2019 11:45:07 -0800 Subject: [PATCH 1/7] Patch call for DDoS Protection plan --- .../stable/2018-11-01/ddosProtectionPlan.json | 58 +++++++++++++++++++ .../DdosProtectionPlanUpdateTags.json | 33 +++++++++++ .../stable/2018-12-01/ddosProtectionPlan.json | 58 +++++++++++++++++++ .../DdosProtectionPlanUpdateTags.json | 33 +++++++++++ 4 files changed, 182 insertions(+) create mode 100644 specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosProtectionPlanUpdateTags.json create mode 100644 specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosProtectionPlanUpdateTags.json diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json index b20425a6aad6..cf73f4694b24 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json @@ -180,6 +180,64 @@ "$ref": "./examples/DdosProtectionPlanCreate.json" } } + }, + "patch": { + "tags": [ + "DdosProtectionPlans" + ], + "operationId": "DdosProtectionPlans_UpdateTags", + "description": "Update a DDoS protection plan tags", + "parameters": [ + { + "name": "resourceGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the resource group." + }, + { + "name": "ddosProtectionPlanName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the DDoS protection plan." + }, + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "./network.json#/definitions/TagsObject" + }, + "description": "Parameters supplied to the update DDoS protection plan resource tags." + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + } + ], + "responses": { + "200": { + "description": "Update successful. The operation returns the resulting DDoS protection plan resource.", + "schema": { + "$ref": "#/definitions/DdosProtectionPlan" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "#/definitions/CloudError" + } + } + }, + "x-ms-long-running-operation": true, + "x-ms-examples": { + "DDoS protection plan Update tags": { + "$ref": "./examples/DdosProtectionPlanUpdateTags.json" + } + } } }, "/subscriptions/{subscriptionId}/providers/Microsoft.Network/ddosProtectionPlans": { diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosProtectionPlanUpdateTags.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosProtectionPlanUpdateTags.json new file mode 100644 index 000000000000..f996a336c528 --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosProtectionPlanUpdateTags.json @@ -0,0 +1,33 @@ +{ + "parameters": { + "api-version": "2018-11-01", + "subscriptionId": "subid", + "resourceGroupName": "rg1", + "ddosProtectionPlanName": "test-plan", + "parameters": { + "tags": { + "tag1": "value1", + "tag2": "value2" + } + } + }, + "responses": { + "200": { + "body": { + "name": "test-plan", + "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/ddosProtectionPlans/test-plan", + "type": "Microsoft.Network/ddosProtectionPlans", + "location": "westus", + "tags": { + "tag1": "value1", + "tag2": "value2" + }, + "properties": { + "provisioningState": "Succeeded", + "resourceGuid": "00000000-0000-0000-0000-000000000000", + "virtualNetworks": [] + } + } + } + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json index 7ebc2a166b60..24fc2969e979 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json @@ -180,6 +180,64 @@ "$ref": "./examples/DdosProtectionPlanCreate.json" } } + }, + "patch": { + "tags": [ + "DdosProtectionPlans" + ], + "operationId": "DdosProtectionPlans_UpdateTags", + "description": "Update a DDoS protection plan tags", + "parameters": [ + { + "name": "resourceGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the resource group." + }, + { + "name": "ddosProtectionPlanName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the DDoS protection plan." + }, + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "./network.json#/definitions/TagsObject" + }, + "description": "Parameters supplied to the update DDoS protection plan resource tags." + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + } + ], + "responses": { + "200": { + "description": "Update successful. The operation returns the resulting DDoS protection plan resource.", + "schema": { + "$ref": "#/definitions/DdosProtectionPlan" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "#/definitions/CloudError" + } + } + }, + "x-ms-long-running-operation": true, + "x-ms-examples": { + "DDoS protection plan Update tags": { + "$ref": "./examples/DdosProtectionPlanUpdateTags.json" + } + } } }, "/subscriptions/{subscriptionId}/providers/Microsoft.Network/ddosProtectionPlans": { diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosProtectionPlanUpdateTags.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosProtectionPlanUpdateTags.json new file mode 100644 index 000000000000..499288163fa0 --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosProtectionPlanUpdateTags.json @@ -0,0 +1,33 @@ +{ + "parameters": { + "api-version": "2018-12-01", + "subscriptionId": "subid", + "resourceGroupName": "rg1", + "ddosProtectionPlanName": "test-plan", + "parameters": { + "tags": { + "tag1": "value1", + "tag2": "value2" + } + } + }, + "responses": { + "200": { + "body": { + "name": "test-plan", + "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/ddosProtectionPlans/test-plan", + "type": "Microsoft.Network/ddosProtectionPlans", + "location": "westus", + "tags": { + "tag1": "value1", + "tag2": "value2" + }, + "properties": { + "provisioningState": "Succeeded", + "resourceGuid": "00000000-0000-0000-0000-000000000000", + "virtualNetworks": [] + } + } + } + } +} From 095ae94921fe8130982fba22afe3386d0463f9ae Mon Sep 17 00:00:00 2001 From: Manchit Gupta Date: Fri, 8 Mar 2019 11:55:49 -0800 Subject: [PATCH 2/7] Removing unreferenced definition --- .../stable/2018-11-01/ddosProtectionPlan.json | 6 ------ .../stable/2018-12-01/ddosProtectionPlan.json | 6 ------ 2 files changed, 12 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json index cf73f4694b24..1e25bc323241 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json @@ -224,12 +224,6 @@ "schema": { "$ref": "#/definitions/DdosProtectionPlan" } - }, - "default": { - "description": "Error response describing why the operation failed.", - "schema": { - "$ref": "#/definitions/CloudError" - } } }, "x-ms-long-running-operation": true, diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json index 24fc2969e979..67cb1306802b 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json @@ -224,12 +224,6 @@ "schema": { "$ref": "#/definitions/DdosProtectionPlan" } - }, - "default": { - "description": "Error response describing why the operation failed.", - "schema": { - "$ref": "#/definitions/CloudError" - } } }, "x-ms-long-running-operation": true, From 2a6920c06a4bb87cb4c079c77e8d23039b5965bb Mon Sep 17 00:00:00 2001 From: Manchit Gupta Date: Wed, 13 Mar 2019 17:13:50 -0700 Subject: [PATCH 3/7] Addressing review comments. Setting x-ms-long-running-operation to false --- .../Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json | 2 +- .../Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json index 1e25bc323241..abed3e0b7dd3 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json @@ -226,7 +226,7 @@ } } }, - "x-ms-long-running-operation": true, + "x-ms-long-running-operation": false, "x-ms-examples": { "DDoS protection plan Update tags": { "$ref": "./examples/DdosProtectionPlanUpdateTags.json" diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json index 67cb1306802b..8cd41d90d425 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json @@ -226,7 +226,7 @@ } } }, - "x-ms-long-running-operation": true, + "x-ms-long-running-operation": false, "x-ms-examples": { "DDoS protection plan Update tags": { "$ref": "./examples/DdosProtectionPlanUpdateTags.json" From 9cdecf1817eeba5a1a024270c481b5b314d6fc77 Mon Sep 17 00:00:00 2001 From: Manchit Gupta Date: Wed, 13 Mar 2019 17:24:28 -0700 Subject: [PATCH 4/7] Removing tags from Patch call description --- .../stable/2018-11-01/ddosProtectionPlan.json | 8 ++++---- ...mPolicyUpdateTags.json => DdosCustomPolicyUpdate.json} | 0 .../stable/2018-12-01/ddosProtectionPlan.json | 8 ++++---- ...mPolicyUpdateTags.json => DdosCustomPolicyUpdate.json} | 0 4 files changed, 8 insertions(+), 8 deletions(-) rename specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/{DdosCustomPolicyUpdateTags.json => DdosCustomPolicyUpdate.json} (100%) rename specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/{DdosCustomPolicyUpdateTags.json => DdosCustomPolicyUpdate.json} (100%) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json index abed3e0b7dd3..9d94c32302f4 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json @@ -185,8 +185,8 @@ "tags": [ "DdosProtectionPlans" ], - "operationId": "DdosProtectionPlans_UpdateTags", - "description": "Update a DDoS protection plan tags", + "operationId": "DdosProtectionPlans_Update", + "description": "Update a DDoS protection plan", "parameters": [ { "name": "resourceGroupName", @@ -209,7 +209,7 @@ "schema": { "$ref": "./network.json#/definitions/TagsObject" }, - "description": "Parameters supplied to the update DDoS protection plan resource tags." + "description": "Parameters supplied to the update DDoS protection plan resource." }, { "$ref": "./network.json#/parameters/ApiVersionParameter" @@ -229,7 +229,7 @@ "x-ms-long-running-operation": false, "x-ms-examples": { "DDoS protection plan Update tags": { - "$ref": "./examples/DdosProtectionPlanUpdateTags.json" + "$ref": "./examples/DdosProtectionPlanUpdate.json" } } } diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosCustomPolicyUpdateTags.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosCustomPolicyUpdate.json similarity index 100% rename from specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosCustomPolicyUpdateTags.json rename to specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosCustomPolicyUpdate.json diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json index 8cd41d90d425..d5476829129b 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json @@ -185,8 +185,8 @@ "tags": [ "DdosProtectionPlans" ], - "operationId": "DdosProtectionPlans_UpdateTags", - "description": "Update a DDoS protection plan tags", + "operationId": "DdosProtectionPlans_Update", + "description": "Update a DDoS protection plan", "parameters": [ { "name": "resourceGroupName", @@ -209,7 +209,7 @@ "schema": { "$ref": "./network.json#/definitions/TagsObject" }, - "description": "Parameters supplied to the update DDoS protection plan resource tags." + "description": "Parameters supplied to the update DDoS protection plan resource." }, { "$ref": "./network.json#/parameters/ApiVersionParameter" @@ -229,7 +229,7 @@ "x-ms-long-running-operation": false, "x-ms-examples": { "DDoS protection plan Update tags": { - "$ref": "./examples/DdosProtectionPlanUpdateTags.json" + "$ref": "./examples/DdosProtectionPlanUpdate.json" } } } diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosCustomPolicyUpdateTags.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosCustomPolicyUpdate.json similarity index 100% rename from specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosCustomPolicyUpdateTags.json rename to specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosCustomPolicyUpdate.json From 0bf317bf9a25190735c14c5e26d77c14d5dabb77 Mon Sep 17 00:00:00 2001 From: Manchit Gupta Date: Wed, 13 Mar 2019 17:28:34 -0700 Subject: [PATCH 5/7] Fixing the response message description --- .../Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json index d5476829129b..76e94139a448 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json @@ -220,7 +220,7 @@ ], "responses": { "200": { - "description": "Update successful. The operation returns the resulting DDoS protection plan resource.", + "description": "Update successful.", "schema": { "$ref": "#/definitions/DdosProtectionPlan" } From 95feaa8d49ea2c38eaf209e8a20048fdaa0fea89 Mon Sep 17 00:00:00 2001 From: Manchit Gupta Date: Wed, 13 Mar 2019 17:33:20 -0700 Subject: [PATCH 6/7] Removing x-ms-long-running-operation from patch --- .../stable/2018-11-01/ddosProtectionPlan.json | 3 +-- .../stable/2018-12-01/ddosProtectionPlan.json | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json index 9d94c32302f4..8e9bc233d5ce 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json @@ -220,13 +220,12 @@ ], "responses": { "200": { - "description": "Update successful. The operation returns the resulting DDoS protection plan resource.", + "description": "Update successful.", "schema": { "$ref": "#/definitions/DdosProtectionPlan" } } }, - "x-ms-long-running-operation": false, "x-ms-examples": { "DDoS protection plan Update tags": { "$ref": "./examples/DdosProtectionPlanUpdate.json" diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json index 76e94139a448..727d8c90d88e 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json @@ -226,7 +226,6 @@ } } }, - "x-ms-long-running-operation": false, "x-ms-examples": { "DDoS protection plan Update tags": { "$ref": "./examples/DdosProtectionPlanUpdate.json" From 77e50267297a78110a2e72094fb3428c52a81734 Mon Sep 17 00:00:00 2001 From: Manchit Gupta Date: Wed, 13 Mar 2019 17:40:49 -0700 Subject: [PATCH 7/7] fixing the file renames --- ...dosCustomPolicyUpdate.json => DdosCustomPolicyUpdateTags.json} | 0 ...rotectionPlanUpdateTags.json => DdosProtectionPlanUpdate.json} | 0 ...dosCustomPolicyUpdate.json => DdosCustomPolicyUpdateTags.json} | 0 ...rotectionPlanUpdateTags.json => DdosProtectionPlanUpdate.json} | 0 4 files changed, 0 insertions(+), 0 deletions(-) rename specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/{DdosCustomPolicyUpdate.json => DdosCustomPolicyUpdateTags.json} (100%) rename specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/{DdosProtectionPlanUpdateTags.json => DdosProtectionPlanUpdate.json} (100%) rename specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/{DdosCustomPolicyUpdate.json => DdosCustomPolicyUpdateTags.json} (100%) rename specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/{DdosProtectionPlanUpdateTags.json => DdosProtectionPlanUpdate.json} (100%) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosCustomPolicyUpdate.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosCustomPolicyUpdateTags.json similarity index 100% rename from specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosCustomPolicyUpdate.json rename to specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosCustomPolicyUpdateTags.json diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosProtectionPlanUpdateTags.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosProtectionPlanUpdate.json similarity index 100% rename from specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosProtectionPlanUpdateTags.json rename to specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosProtectionPlanUpdate.json diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosCustomPolicyUpdate.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosCustomPolicyUpdateTags.json similarity index 100% rename from specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosCustomPolicyUpdate.json rename to specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosCustomPolicyUpdateTags.json diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosProtectionPlanUpdateTags.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosProtectionPlanUpdate.json similarity index 100% rename from specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosProtectionPlanUpdateTags.json rename to specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosProtectionPlanUpdate.json