Skip to content

Commit 16123df

Browse files
joshharrinJosh Harrington
andauthored
Joharrington/Workspace Managed Network (#28879)
* update swagger, regenerate restclient * managed network property, outbound rule operations * add tests for workspace and outbound rules * test runs and test cassette recordings * run black, fix pylint complaints * update workspace keys model to api used --------- Co-authored-by: Josh Harrington <joharrington@microsoft.com>
1 parent 3e51d17 commit 16123df

File tree

43 files changed

+16519
-5816
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+16519
-5816
lines changed

sdk/ml/azure-ai-ml/azure/ai/ml/_arm_deployments/arm_templates/workspace_base.json

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -386,6 +386,15 @@
386386
"metadata": {
387387
"description": "ARM identifier of primary user assigned managed identity, in case multiple ones are specified. Also the default managed identity for clusterless compute."
388388
}
389+
},
390+
"managedNetwork": {
391+
"type": "object",
392+
"defaultValue": {
393+
"isolationMode": "Disabled"
394+
},
395+
"metadata": {
396+
"description": "Managed network settings to be used for the workspace. If not specified, isolation mode Disabled is the default"
397+
}
389398
}
390399
},
391400
"variables": {
@@ -543,7 +552,7 @@
543552
{
544553
"condition": "[variables('enablePE')]",
545554
"type": "Microsoft.MachineLearningServices/workspaces",
546-
"apiVersion": "2022-01-01-preview",
555+
"apiVersion": "2022-12-01-preview",
547556
"tags": "[parameters('tagValues')]",
548557
"name": "[parameters('workspaceName')]",
549558
"location": "[parameters('location')]",
@@ -576,7 +585,8 @@
576585
"storageAccountArmId": "[parameters('encryption_storage_resourceid')]",
577586
"SearchAccountArmId": "[parameters('encryption_search_resourceid')]"
578587
},
579-
"primaryUserAssignedIdentity": "[parameters('primaryUserAssignedIdentity')]"
588+
"primaryUserAssignedIdentity": "[parameters('primaryUserAssignedIdentity')]",
589+
"managedNetwork": "[parameters('managedNetwork')]"
580590
}
581591
},
582592
{

sdk/ml/azure-ai-ml/azure/ai/ml/_arm_deployments/arm_templates/workspace_param.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,5 +115,8 @@
115115
},
116116
"primaryUserAssignedIdentity": {
117117
"value": ""
118+
},
119+
"managedNetwork": {
120+
"value": {}
118121
}
119122
}

sdk/ml/azure-ai-ml/azure/ai/ml/_ml_client.py

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@
7676
VirtualClusterOperations,
7777
WorkspaceConnectionsOperations,
7878
WorkspaceOperations,
79+
WorkspaceOutboundRuleOperations,
7980
)
8081
from azure.ai.ml.operations._code_operations import CodeOperations
8182
from azure.ai.ml.operations._local_deployment_helper import _LocalDeploymentHelper
@@ -223,7 +224,7 @@ def __init__(
223224
**kwargs,
224225
)
225226

226-
self._rp_service_client = ServiceClient102022Preview(
227+
self._rp_service_client = ServiceClient122022Preview(
227228
subscription_id=self._operation_scope._subscription_id,
228229
credential=self._credential,
229230
base_url=base_url,
@@ -296,6 +297,14 @@ def __init__(
296297
**app_insights_handler_kwargs,
297298
)
298299

300+
self._workspace_outbound_rule = WorkspaceOutboundRuleOperations(
301+
self._operation_scope,
302+
self._rp_service_client,
303+
self._operation_container,
304+
self._credential,
305+
**kwargs,
306+
)
307+
299308
# TODO make sure that at least one reviewer who understands operation initialization details reviews this
300309
self._registries = RegistryOperations(
301310
self._operation_scope,
@@ -553,6 +562,14 @@ def workspaces(self) -> WorkspaceOperations:
553562
"""
554563
return self._workspaces
555564

565+
@property
566+
def workspace_outbound_rule(self) -> WorkspaceOutboundRuleOperations:
567+
"""A collection of workspace managed network outbound rule related operations.
568+
:return: Workspace Outbound Rule operations
569+
:rtype: WorkspaceOutboundRuleOperations
570+
"""
571+
return self._workspace_outbound_rule
572+
556573
@property
557574
@experimental
558575
def registries(self) -> RegistryOperations:

sdk/ml/azure-ai-ml/azure/ai/ml/_restclient/v2022_12_01_preview/_azure_machine_learning_workspaces.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
from . import models
1717
from ._configuration import AzureMachineLearningWorkspacesConfiguration
18-
from .operations import BatchDeploymentsOperations, BatchEndpointsOperations, CodeContainersOperations, CodeVersionsOperations, ComponentContainersOperations, ComponentVersionsOperations, ComputeOperations, DataContainersOperations, DataVersionsOperations, DatastoresOperations, EnvironmentContainersOperations, EnvironmentVersionsOperations, JobsOperations, LabelingJobsOperations, ModelContainersOperations, ModelVersionsOperations, OnlineDeploymentsOperations, OnlineEndpointsOperations, Operations, PrivateEndpointConnectionsOperations, PrivateLinkResourcesOperations, QuotasOperations, RegistriesOperations, RegistryCodeContainersOperations, RegistryCodeVersionsOperations, RegistryComponentContainersOperations, RegistryComponentVersionsOperations, RegistryEnvironmentContainersOperations, RegistryEnvironmentVersionsOperations, RegistryModelContainersOperations, RegistryModelVersionsOperations, SchedulesOperations, UsagesOperations, VirtualMachineSizesOperations, WorkspaceConnectionsOperations, WorkspaceFeaturesOperations, WorkspacesOperations
18+
from .operations import BatchDeploymentsOperations, BatchEndpointsOperations, CodeContainersOperations, CodeVersionsOperations, ComponentContainersOperations, ComponentVersionsOperations, ComputeOperations, DataContainersOperations, DataVersionsOperations, DatastoresOperations, EnvironmentContainersOperations, EnvironmentVersionsOperations, JobsOperations, LabelingJobsOperations, ManagedNetworkSettingsOperations, ManagedNetworkSettingsRuleOperations, ModelContainersOperations, ModelVersionsOperations, OnlineDeploymentsOperations, OnlineEndpointsOperations, Operations, PrivateEndpointConnectionsOperations, PrivateLinkResourcesOperations, QuotasOperations, RegistriesOperations, RegistryCodeContainersOperations, RegistryCodeVersionsOperations, RegistryComponentContainersOperations, RegistryComponentVersionsOperations, RegistryEnvironmentContainersOperations, RegistryEnvironmentVersionsOperations, RegistryModelContainersOperations, RegistryModelVersionsOperations, SchedulesOperations, UsagesOperations, VirtualMachineSizesOperations, WorkspaceConnectionsOperations, WorkspaceFeaturesOperations, WorkspacesOperations
1919

2020
if TYPE_CHECKING:
2121
# pylint: disable=unused-import,ungrouped-imports
@@ -49,6 +49,12 @@ class AzureMachineLearningWorkspaces(object): # pylint: disable=too-many-inst
4949
:ivar workspace_connections: WorkspaceConnectionsOperations operations
5050
:vartype workspace_connections:
5151
azure.mgmt.machinelearningservices.operations.WorkspaceConnectionsOperations
52+
:ivar managed_network_settings: ManagedNetworkSettingsOperations operations
53+
:vartype managed_network_settings:
54+
azure.mgmt.machinelearningservices.operations.ManagedNetworkSettingsOperations
55+
:ivar managed_network_settings_rule: ManagedNetworkSettingsRuleOperations operations
56+
:vartype managed_network_settings_rule:
57+
azure.mgmt.machinelearningservices.operations.ManagedNetworkSettingsRuleOperations
5258
:ivar registries: RegistriesOperations operations
5359
:vartype registries: azure.mgmt.machinelearningservices.operations.RegistriesOperations
5460
:ivar workspace_features: WorkspaceFeaturesOperations operations
@@ -162,6 +168,8 @@ def __init__(
162168
self.private_endpoint_connections = PrivateEndpointConnectionsOperations(self._client, self._config, self._serialize, self._deserialize)
163169
self.private_link_resources = PrivateLinkResourcesOperations(self._client, self._config, self._serialize, self._deserialize)
164170
self.workspace_connections = WorkspaceConnectionsOperations(self._client, self._config, self._serialize, self._deserialize)
171+
self.managed_network_settings = ManagedNetworkSettingsOperations(self._client, self._config, self._serialize, self._deserialize)
172+
self.managed_network_settings_rule = ManagedNetworkSettingsRuleOperations(self._client, self._config, self._serialize, self._deserialize)
165173
self.registries = RegistriesOperations(self._client, self._config, self._serialize, self._deserialize)
166174
self.workspace_features = WorkspaceFeaturesOperations(self._client, self._config, self._serialize, self._deserialize)
167175
self.registry_code_containers = RegistryCodeContainersOperations(self._client, self._config, self._serialize, self._deserialize)

sdk/ml/azure-ai-ml/azure/ai/ml/_restclient/v2022_12_01_preview/aio/_azure_machine_learning_workspaces.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
from .. import models
1818
from ._configuration import AzureMachineLearningWorkspacesConfiguration
19-
from .operations import BatchDeploymentsOperations, BatchEndpointsOperations, CodeContainersOperations, CodeVersionsOperations, ComponentContainersOperations, ComponentVersionsOperations, ComputeOperations, DataContainersOperations, DataVersionsOperations, DatastoresOperations, EnvironmentContainersOperations, EnvironmentVersionsOperations, JobsOperations, LabelingJobsOperations, ModelContainersOperations, ModelVersionsOperations, OnlineDeploymentsOperations, OnlineEndpointsOperations, Operations, PrivateEndpointConnectionsOperations, PrivateLinkResourcesOperations, QuotasOperations, RegistriesOperations, RegistryCodeContainersOperations, RegistryCodeVersionsOperations, RegistryComponentContainersOperations, RegistryComponentVersionsOperations, RegistryEnvironmentContainersOperations, RegistryEnvironmentVersionsOperations, RegistryModelContainersOperations, RegistryModelVersionsOperations, SchedulesOperations, UsagesOperations, VirtualMachineSizesOperations, WorkspaceConnectionsOperations, WorkspaceFeaturesOperations, WorkspacesOperations
19+
from .operations import BatchDeploymentsOperations, BatchEndpointsOperations, CodeContainersOperations, CodeVersionsOperations, ComponentContainersOperations, ComponentVersionsOperations, ComputeOperations, DataContainersOperations, DataVersionsOperations, DatastoresOperations, EnvironmentContainersOperations, EnvironmentVersionsOperations, JobsOperations, LabelingJobsOperations, ManagedNetworkSettingsOperations, ManagedNetworkSettingsRuleOperations, ModelContainersOperations, ModelVersionsOperations, OnlineDeploymentsOperations, OnlineEndpointsOperations, Operations, PrivateEndpointConnectionsOperations, PrivateLinkResourcesOperations, QuotasOperations, RegistriesOperations, RegistryCodeContainersOperations, RegistryCodeVersionsOperations, RegistryComponentContainersOperations, RegistryComponentVersionsOperations, RegistryEnvironmentContainersOperations, RegistryEnvironmentVersionsOperations, RegistryModelContainersOperations, RegistryModelVersionsOperations, SchedulesOperations, UsagesOperations, VirtualMachineSizesOperations, WorkspaceConnectionsOperations, WorkspaceFeaturesOperations, WorkspacesOperations
2020

2121
if TYPE_CHECKING:
2222
# pylint: disable=unused-import,ungrouped-imports
@@ -47,6 +47,12 @@ class AzureMachineLearningWorkspaces: # pylint: disable=too-many-instance-att
4747
:ivar workspace_connections: WorkspaceConnectionsOperations operations
4848
:vartype workspace_connections:
4949
azure.mgmt.machinelearningservices.aio.operations.WorkspaceConnectionsOperations
50+
:ivar managed_network_settings: ManagedNetworkSettingsOperations operations
51+
:vartype managed_network_settings:
52+
azure.mgmt.machinelearningservices.aio.operations.ManagedNetworkSettingsOperations
53+
:ivar managed_network_settings_rule: ManagedNetworkSettingsRuleOperations operations
54+
:vartype managed_network_settings_rule:
55+
azure.mgmt.machinelearningservices.aio.operations.ManagedNetworkSettingsRuleOperations
5056
:ivar registries: RegistriesOperations operations
5157
:vartype registries: azure.mgmt.machinelearningservices.aio.operations.RegistriesOperations
5258
:ivar workspace_features: WorkspaceFeaturesOperations operations
@@ -163,6 +169,8 @@ def __init__(
163169
self.private_endpoint_connections = PrivateEndpointConnectionsOperations(self._client, self._config, self._serialize, self._deserialize)
164170
self.private_link_resources = PrivateLinkResourcesOperations(self._client, self._config, self._serialize, self._deserialize)
165171
self.workspace_connections = WorkspaceConnectionsOperations(self._client, self._config, self._serialize, self._deserialize)
172+
self.managed_network_settings = ManagedNetworkSettingsOperations(self._client, self._config, self._serialize, self._deserialize)
173+
self.managed_network_settings_rule = ManagedNetworkSettingsRuleOperations(self._client, self._config, self._serialize, self._deserialize)
166174
self.registries = RegistriesOperations(self._client, self._config, self._serialize, self._deserialize)
167175
self.workspace_features = WorkspaceFeaturesOperations(self._client, self._config, self._serialize, self._deserialize)
168176
self.registry_code_containers = RegistryCodeContainersOperations(self._client, self._config, self._serialize, self._deserialize)

sdk/ml/azure-ai-ml/azure/ai/ml/_restclient/v2022_12_01_preview/aio/operations/__init__.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
from ._private_endpoint_connections_operations import PrivateEndpointConnectionsOperations
1616
from ._private_link_resources_operations import PrivateLinkResourcesOperations
1717
from ._workspace_connections_operations import WorkspaceConnectionsOperations
18+
from ._managed_network_settings_operations import ManagedNetworkSettingsOperations
19+
from ._managed_network_settings_rule_operations import ManagedNetworkSettingsRuleOperations
1820
from ._registries_operations import RegistriesOperations
1921
from ._workspace_features_operations import WorkspaceFeaturesOperations
2022
from ._registry_code_containers_operations import RegistryCodeContainersOperations
@@ -54,6 +56,8 @@
5456
'PrivateEndpointConnectionsOperations',
5557
'PrivateLinkResourcesOperations',
5658
'WorkspaceConnectionsOperations',
59+
'ManagedNetworkSettingsOperations',
60+
'ManagedNetworkSettingsRuleOperations',
5761
'RegistriesOperations',
5862
'WorkspaceFeaturesOperations',
5963
'RegistryCodeContainersOperations',

0 commit comments

Comments
 (0)