Skip to content

Commit d688090

Browse files
author
yijxie
committed
Revert "Merge branch 'eventhubs_dev' into eventhubs_eph"
This reverts commit 19a5539, reversing changes made to 9d18dd9.
1 parent 997dacf commit d688090

File tree

6 files changed

+4
-16
lines changed

6 files changed

+4
-16
lines changed

sdk/eventhub/azure-eventhubs/azure/eventhub/_consumer_producer_mixin.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,6 @@ def _open(self, timeout_time=None):
6464
"""
6565
# pylint: disable=protected-access
6666
if not self.running:
67-
if self._handler:
68-
self._handler.close()
6967
if self.redirected:
7068
alt_creds = {
7169
"username": self.client._auth_config.get("iot_username"),

sdk/eventhub/azure-eventhubs/azure/eventhub/aio/_consumer_producer_mixin_async.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,6 @@ async def _open(self, timeout_time=None):
6565
"""
6666
# pylint: disable=protected-access
6767
if not self.running:
68-
if self._handler:
69-
await self._handler.close_async()
7068
if self.redirected:
7169
alt_creds = {
7270
"username": self.client._auth_config.get("iot_username"),

sdk/eventhub/azure-eventhubs/azure/eventhub/producer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ def send(self, event_data, partition_key=None, timeout=None):
223223
wrapper_event_data = event_data
224224
else:
225225
if partition_key:
226-
event_data = _set_partition_key(event_data, partition_key)
226+
event_data = self._set_partition_key(event_data, partition_key)
227227
wrapper_event_data = EventDataBatch._from_batch(event_data, partition_key) # pylint: disable=protected-access
228228
wrapper_event_data.message.on_send_complete = self._on_outcome
229229
self.unsent_events = [wrapper_event_data.message]

sdk/eventhub/azure-eventhubs/tests/asynctests/test_negative_async.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ async def test_send_with_invalid_hostname_async(invalid_hostname, connstr_receiv
3030
sender = client.create_producer()
3131
with pytest.raises(AuthenticationError):
3232
await sender.send(EventData("test data"))
33-
await sender.close()
3433

3534

3635
@pytest.mark.liveTest
@@ -40,7 +39,6 @@ async def test_receive_with_invalid_hostname_async(invalid_hostname):
4039
receiver = client.create_consumer(consumer_group="$default", partition_id="0", event_position=EventPosition("-1"))
4140
with pytest.raises(AuthenticationError):
4241
await receiver.receive(timeout=3)
43-
await receiver.close()
4442

4543

4644
@pytest.mark.liveTest
@@ -51,7 +49,6 @@ async def test_send_with_invalid_key_async(invalid_key, connstr_receivers):
5149
sender = client.create_producer()
5250
with pytest.raises(AuthenticationError):
5351
await sender.send(EventData("test data"))
54-
await sender.close()
5552

5653

5754
@pytest.mark.liveTest
@@ -61,7 +58,6 @@ async def test_receive_with_invalid_key_async(invalid_key):
6158
receiver = client.create_consumer(consumer_group="$default", partition_id="0", event_position=EventPosition("-1"))
6259
with pytest.raises(AuthenticationError):
6360
await receiver.receive(timeout=3)
64-
await receiver.close()
6561

6662

6763
@pytest.mark.liveTest
@@ -72,7 +68,6 @@ async def test_send_with_invalid_policy_async(invalid_policy, connstr_receivers)
7268
sender = client.create_producer()
7369
with pytest.raises(AuthenticationError):
7470
await sender.send(EventData("test data"))
75-
await sender.close()
7671

7772

7873
@pytest.mark.liveTest
@@ -82,7 +77,6 @@ async def test_receive_with_invalid_policy_async(invalid_policy):
8277
receiver = client.create_consumer(consumer_group="$default", partition_id="0", event_position=EventPosition("-1"))
8378
with pytest.raises(AuthenticationError):
8479
await receiver.receive(timeout=3)
85-
await receiver.close()
8680

8781

8882
@pytest.mark.liveTest

sdk/eventhub/azure-eventhubs/tests/test_negative.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ def test_send_with_invalid_hostname(invalid_hostname, connstr_receivers):
2727
sender = client.create_producer()
2828
with pytest.raises(AuthenticationError):
2929
sender.send(EventData("test data"))
30-
sender.close()
3130

3231

3332
@pytest.mark.liveTest
@@ -48,7 +47,6 @@ def test_send_with_invalid_key(invalid_key, connstr_receivers):
4847
sender.send(EventData("test data"))
4948
sender.close()
5049

51-
5250
@pytest.mark.liveTest
5351
def test_receive_with_invalid_key_sync(invalid_key):
5452
client = EventHubClient.from_connection_string(invalid_key, network_tracing=False)
@@ -98,13 +96,13 @@ def test_non_existing_entity_sender(connection_str):
9896
sender = client.create_producer(partition_id="1")
9997
with pytest.raises(AuthenticationError):
10098
sender.send(EventData("test data"))
101-
sender.close()
10299

103100

104101
@pytest.mark.liveTest
105102
def test_non_existing_entity_receiver(connection_str):
106103
client = EventHubClient.from_connection_string(connection_str, event_hub_path="nemo", network_tracing=False)
107104
receiver = client.create_consumer(consumer_group="$default", partition_id="0", event_position=EventPosition("-1"))
105+
108106
with pytest.raises(AuthenticationError):
109107
receiver.receive(timeout=5)
110108
receiver.close()

sdk/eventhub/azure-eventhubs/tests/test_receive.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,10 +148,10 @@ def test_receive_with_custom_datetime_sync(connstr_senders):
148148
receiver = client.create_consumer(consumer_group="$default", partition_id="0", event_position=EventPosition(offset))
149149
with receiver:
150150
all_received = []
151-
received = receiver.receive(timeout=5)
151+
received = receiver.receive(timeout=1)
152152
while received:
153153
all_received.extend(received)
154-
received = receiver.receive(timeout=5)
154+
received = receiver.receive(timeout=1)
155155

156156
assert len(all_received) == 5
157157
for received_event in all_received:

0 commit comments

Comments
 (0)