[Identity] Support expires_on in AzureCLICredential#33947
Merged
pvaneck merged 3 commits intoAzure:mainfrom Jan 23, 2024
Merged
[Identity] Support expires_on in AzureCLICredential#33947pvaneck merged 3 commits intoAzure:mainfrom
pvaneck merged 3 commits intoAzure:mainfrom
Conversation
pvaneck
force-pushed
the
identity-expires-on
branch
from
2465d9e to
dc1a3e2
Compare
Collaborator
|
API change check API changes are not detected in this pull request. |
Newer versions of Azure CLI now also return a Unix timestamp with the `expires_on` field when retrieving an access token. We should prefer using that. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
identity-expires-on
branch
from
dc1a3e2 to
819a23e
Compare
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
requested review from
ahsonkhan,
billwert,
g2vinay,
joshfree,
maorleger and
mpodwysocki
maorleger
reviewed
Jan 22, 2024
Member
maorleger
left a comment
maorleger
left a comment
There was a problem hiding this comment.
Had a few questions about formatting and units for the expiry timestamp
xiangyan99
reviewed
Jan 23, 2024
xiangyan99
approved these changes
Jan 23, 2024
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-python
that referenced
this pull request
Feb 16, 2024
Newer versions of Azure CLI now also return a Unix timestamp with the `expires_on` field when retrieving an access token. We should prefer using that. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions of Azure CLI now also return a Unix timestamp with the
expires_onfield when retrieving an access token. We should prefer using that.Closes: #32952