support lint fix command in js release tool (#11722)

* support lint fix command in js release tool

* Update devToolUtils.ts

* update

* Revert "update"

This reverts commit fdbbd85.

* Update devToolUtils.ts

* Revert "Update devToolUtils.ts"

This reverts commit 1f429d8.

* Update devToolUtils.ts

* Update devToolUtils.ts

* test code

* test code

* Update devToolUtils.ts

* try to use root path

* Revert "try to use root path"

This reverts commit d4b0161.

* Update devToolUtils.ts

* Update devToolUtils.ts

* bump version

Author: kazrael2119

tools/js-sdk-release-tools/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@azure-tools/js-sdk-release-tools",
-  "version": "2.14.2",
+  "version": "2.14.3",
   "description": "",
   "files": [
     "dist"

tools/js-sdk-release-tools/package.json

@@ -1,5 +1,7 @@
 
 import { logger } from '../utils/logger.js';
+import * as path from 'path';
+import { exists } from 'fs-extra';
 import { runCommand, runCommandOptions } from './utils.js';
 
 export async function formatSdk(packageDirectory: string) {
@@ -29,4 +31,24 @@ export async function updateSnippets(packageDirectory: string) {
     } catch (error) {
         logger.warn(`Failed to update snippets due to: ${(error as Error)?.stack ?? error}`);
     }
+}
+
+export async function lintFix(packageDirectory: string) {
+    const hasSampleFolder = await exists(path.join(packageDirectory, "samples-dev"));
+    const samplesDev = hasSampleFolder ? ' samples-dev' : '';
+    const cwd = packageDirectory;
+    const options = { ...runCommandOptions, cwd };
+
+    logger.info("Start to build @azure/eslint-plugin-azure-sdk package to install eslint dependency.");
+    await runCommand('pnpm', ['build', '--filter', `@azure/eslint-plugin-azure-sdk...`], runCommandOptions);
+    logger.info("Build @azure/eslint-plugin-azure-sdk package successfully.");
+    logger.info(`Start to fix lint errors in '${packageDirectory}'.`);
+    const lintFixCommand = `run vendored eslint package.json api-extractor.json src test${samplesDev} --fix --fix-type [problem,suggestion]`;
+
+    try {
+        await runCommand(`npm`, ['exec', '--', 'dev-tool', lintFixCommand], options, true, 300, true);
+        logger.info(`Fix the automatically repairable lint errors successfully.`);
+    } catch (error) {
+        logger.warn(`Failed to fix lint errors due to: ${(error as Error)?.stack ?? error}`);
+    }
 }

tools/js-sdk-release-tools/src/common/devToolUtils.ts

@@ -11,7 +11,7 @@ import { glob } from 'glob';
 import { logger } from '../utils/logger.js';
 import unixify from 'unixify';
 import { existsSync } from 'fs';
-import { formatSdk, updateSnippets } from './devToolUtils.js';
+import { formatSdk, lintFix, updateSnippets } from './devToolUtils.js';
 
 interface ProjectItem {
     packageName: string;
@@ -134,6 +134,8 @@ export async function buildPackage(
         await runCommand(`pnpm`, ['install'], runCommandOptions, false);
         logger.info(`Pnpm install successfully.`);
 
+        await lintFix(packageDirectory);
+
         logger.info(`Start to build package '${name}'.`);
         await runCommand('pnpm', ['build', '--filter', `${name}...`], runCommandOptions);
     }

tools/js-sdk-release-tools/src/common/rushUtils.ts

@@ -16,7 +16,7 @@ import {getReleaseTool} from "./utils/getReleaseTool.js";
 import { addApiViewInfo } from "../utils/addApiViewInfo.js";
 import { defaultChildProcessTimeout } from '../common/utils.js'
 import { isRushRepo } from "../common/rushUtils.js";
-import { updateSnippets } from "../common/devToolUtils.js";
+import { lintFix, updateSnippets } from "../common/devToolUtils.js";
 import { ChangelogResult } from "../changelog/v2/ChangelogGenerator.js";
 
 export async function generateMgmt(options: {
@@ -131,6 +131,8 @@ export async function generateMgmt(options: {
             } else {
                 logger.info(`Start to run command: 'pnpm install'.`);
                 execSync('pnpm install', {stdio: 'inherit'});
+
+                await lintFix(packagePath);
 
                 logger.info(`Start to run command: 'pnpm build --filter ${packageName}...', that builds generated codes, except test and sample, which may be written manually.`);
                 execSync(`pnpm build --filter ${packageName}...`, {stdio: 'inherit'});

tools/js-sdk-release-tools/src/hlc/generateMgmt.ts

@@ -22,7 +22,7 @@ import { remove } from 'fs-extra';
 import { generateChangelogAndBumpVersion } from "../../common/changelog/automaticGenerateChangeLogAndBumpVersion.js";
 import { updateChangelogResult } from "../../common/packageResultUtils.js";
 import { isRushRepo } from "../../common/rushUtils.js";
-import { formatSdk, updateSnippets } from "../../common/devToolUtils.js";
+import { formatSdk, updateSnippets, lintFix } from "../../common/devToolUtils.js";
 import { RunMode } from "../../common/types.js";
 import { exists } from 'fs-extra';
 
@@ -272,6 +272,8 @@ export async function generateRLCInPipeline(options: {
         } else {
             logger.info(`Start to update.`);
             execSync('pnpm install', {stdio: 'inherit'});
+
+            await lintFix(packagePath);
 
             logger.info(`Start to build '${packageName}', except for tests and samples, which may be written manually.`);
             // To build generated codes except test and sample, we need to change tsconfig.json.