Skip to content

Conversation

@kazup01
Copy link
Member

@kazup01 kazup01 commented Jul 5, 2017

screen shot 0029-07-06 at 2 34 28 am

@kazup01 kazup01 requested a review from asmsuechan July 5, 2017 17:35
type: 'MARKDOWN_NOTE',
folder: data.storage.folders[0].key,
title: 'Welcome to Boostnote!',
content: '# Welcome to Boostnote! \n### _Click to edit this note._\n\n---\n\nBoostnote is an *open source* note-taking app. \nRepository is published on [GitHub](https://github.com/BoostIO/Boostnote), and tweeting everyday on [@Boostnoteapp](https://twitter.com/boostnoteapp)!\n\n## Features \n- [x] No Internet and Registration Required. \n- [ ] Quick search and copy the content of note. `macOS: Cmd + Alt + S / windows: Super + Alt + S` \n- [ ] Markdown & Snippet note. \n- [ ] Available for `vim` and `emacs` mode. \n- [ ] Choose your favorite theme on UI, Editor and Code Block! \n--- \n\n- Copy Codeblock on Makrdown Preview.\n```javascript\nvar boostnote = document.getElementById(\'enjoy\').innerHTML\n\nconsole.log(boostnote)\n```'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windows: Super + Alt + S

Ctrl?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix💯

note: note
})
})
let defaultMarkdownNote = dataApi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any reasons what you moved the variable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it changes order of the first two contents (markdown and snippet).

Before
screen shot 0029-07-07 at 6 37 08 pm

After
screen shot 0029-07-07 at 6 36 59 pm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood

@asmsuechan
Copy link
Contributor

Works fine.
screen shot 2017-07-07 at 20 58 22

@asmsuechan asmsuechan merged commit bdefaf7 into master Jul 7, 2017
@asmsuechan asmsuechan deleted the edit-initial-files branch July 7, 2017 11:59
@kohei-takata kohei-takata mentioned this pull request Jul 29, 2017
@kazup01 kazup01 mentioned this pull request Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants