Skip to content

Commit 6c00ccd

Browse files
committed
Improve node.js version check.
1 parent 075bb9d commit 6c00ccd

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

CloudI.js

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,16 +73,23 @@ var packUint32big = function packUint32big (value) {
7373
value & 0xff]);
7474
};
7575
var nodejs_version = process.versions['node'].split('.').map(s => parseInt(s));
76-
var nodejsVersionAfter = function nodejsVersionAfter (s) {
76+
var nodejsVersionAfter = function nodejsVersionAfter (s, include) {
7777
var v = s.split('.').map(s => parseInt(s));
78+
var compare;
79+
if (include) {
80+
compare = function (lhs, rhs) { return (lhs >= rhs); };
81+
}
82+
else {
83+
compare = function (lhs, rhs) { return (lhs > rhs); };
84+
}
7885
for (var i = 0; i < v.length; i++) {
79-
if (nodejs_version[i] > v[i]) {
86+
if (compare(nodejs_version[i], v[i])) {
8087
return true;
8188
}
8289
}
8390
return false;
8491
};
85-
if (nodejsVersionAfter('10.0.0')) {
92+
if (nodejsVersionAfter('10.0.0',true)) {
8693
var originalEmitWarning = process.emitWarning;
8794
process.emitWarning = function(warning, type, code, ctor) {
8895
if (code === 'DEP0097') {
@@ -235,7 +242,7 @@ CloudI.API = function API (thread_index, callback) {
235242
else {
236243
throw new InvalidInputException();
237244
}
238-
if (nodejsVersionAfter('0.12.1')) {
245+
if (nodejsVersionAfter('0.12.1',false)) {
239246
API._s_in = new net.Socket({fd: (thread_index + 3),
240247
readable: true,
241248
writable: true});

0 commit comments

Comments
 (0)