This repository was archived by the owner on Dec 14, 2021. It is now read-only.
Merged
Conversation
egraether
pushed a commit
that referenced
this pull request
Dec 16, 2019
* build: add missing includes in header files * logic: delete components in reverse to creation order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've caught an exeption on app exit:
The problem is that
TabsControllerdepends onScreenSearchControllerandScreenSearchControllergets destroyed beforeTabsControllerleaving him hanging on a dead object.The proposed solution is to destroy components in the order reverse to creation
Steps to reproduce:
Full stacktrace