Allow changing the log file path in preferences#900
Allow changing the log file path in preferences#900mlangkabel merged 7 commits intoCoatiSoftware:masterfrom
Conversation
mlangkabel
left a comment
There was a problem hiding this comment.
Thanks for handing in this pull request! The code is looking good already, but please fix the things I mentioned in my review.
Apart from that, it would be great if the log file path of the logger is set if the user saves and closes the application settings. Otherwise the settings do not match what really happens.
src/lib_gui/qt/project_wizard/content/QtProjectWizardContentPreferences.cpp
Show resolved
Hide resolved
src/lib_gui/qt/project_wizard/content/QtProjectWizardContentPreferences.cpp
Outdated
Show resolved
Hide resolved
src/lib_gui/qt/project_wizard/content/QtProjectWizardContentPreferences.cpp
Outdated
Show resolved
Hide resolved
src/lib_gui/qt/project_wizard/content/QtProjectWizardContentPreferences.cpp
Outdated
Show resolved
Hide resolved
|
Applied requested changes:
|
mlangkabel
left a comment
There was a problem hiding this comment.
Thank you for your changes. I left some comments where the code formatting was still off.
I also tested the changes on my system and it is not working. Did you test this? Is it working for you? Does Sourcetrail write the log files to the new location after you change the log directory in the preferences?
src/lib_gui/qt/project_wizard/content/QtProjectWizardContentPreferences.cpp
Outdated
Show resolved
Hide resolved
|
Updated.
|
|
Looking good now. Thanks again for implementing this feature! |
#156