This repository was archived by the owner on Dec 14, 2021. It is now read-only.
Merged
Conversation
Refactor image generation into separate function
Contributor
|
Interesting use-case and idea. Implementation looks good to me. I think the naming is ok (would probably have named it the same way). I tested it on macOS and it works. I can paste from clipboard into Mail, Slack, Skype, WhatsApp Web. Thanks for implementing! |
mlangkabel
pushed a commit
that referenced
this pull request
May 8, 2020
* Refactor image generation into separate function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the context option "Save to Clipboard" to the graph viewer. It is bundled together with the "Save as Image" action.
Motivation
I often use Sourcetrail alongside a discussion about a design or implementation decision with colleagues.
When such a discussion happens via teleconferencing tool, sending a snapshop of the graph is very useful, but is rather long or cumbersome procedure. Either Save, pick location and name, then open chat, find file, and finally load it; or use a system tool to copy a section of the screen and paste.
With this change, the above simply turns into "Save to Clipboard, open chat, paste"
Reviewers
I am not really happy with the internal name
QtGraphicsView::copyGraphand the menu itemSave to Clipboardof this feature, but couldn't come up with something better. Do you have suggestions?