Mark more members as 'readonly'

Author: Sergio0694

src/CommunityToolkit.HighPerformance/Buffers/StringPool.cs

@@ -376,7 +376,7 @@ public FixedSizePriorityMap(int capacity)
         /// <summary>
         /// Gets an <see cref="object"/> that can be used to synchronize access to the current instance.
         /// </summary>
-        public object SyncRoot
+        public readonly object SyncRoot
         {
             [MethodImpl(MethodImplOptions.AggressiveInlining)]
             get => this.buckets;
@@ -749,7 +749,7 @@ private void UpdateTimestamp(ref int heapIndex)
         /// a given number of nodes, those are all contiguous from the start of the array.
         /// </summary>
         [MethodImpl(MethodImplOptions.NoInlining)]
-        private void UpdateAllTimestamps()
+        private readonly void UpdateAllTimestamps()
         {
             int count = this.count;
             ref HeapEntry heapEntriesRef = ref this.heapEntries.DangerousGetReference();

src/CommunityToolkit.Mvvm.SourceGenerators/Helpers/HashCode.cs

@@ -134,7 +134,7 @@ private void Add(int value)
     /// Gets the resulting hashcode from the current instance.
     /// </summary>
     /// <returns>The resulting hashcode from the current instance.</returns>
-    public int ToHashCode()
+    public readonly int ToHashCode()
     {
         uint length = this.length;
         uint position = length % 4;
@@ -165,12 +165,12 @@ public int ToHashCode()
     /// <inheritdoc/>
     [Obsolete("HashCode is a mutable struct and should not be compared with other HashCodes. Use ToHashCode to retrieve the computed hash code.", error: true)]
     [EditorBrowsable(EditorBrowsableState.Never)]
-    public override int GetHashCode() => throw new NotSupportedException();
+    public override readonly int GetHashCode() => throw new NotSupportedException();
 
     /// <inheritdoc/>
     [Obsolete("HashCode is a mutable struct and should not be compared with other HashCodes.", error: true)]
     [EditorBrowsable(EditorBrowsableState.Never)]
-    public override bool Equals(object? obj) => throw new NotSupportedException();
+    public override readonly bool Equals(object? obj) => throw new NotSupportedException();
 
     /// <summary>
     /// Rotates the specified value left by the specified number of bits.

src/CommunityToolkit.Mvvm/Messaging/Internals/ArrayPoolBufferWriter{T}.cs

@@ -58,7 +58,7 @@ public static ArrayPoolBufferWriter<T> Create()
     /// <summary>
     /// Gets a <see cref="ReadOnlySpan{T}"/> with the current items.
     /// </summary>
-    public ReadOnlySpan<T> Span
+    public readonly ReadOnlySpan<T> Span
     {
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         get => this.span.Slice(0, this.index);
@@ -116,7 +116,7 @@ private void ResizeBufferAndAdd(T item)
     }
 
     /// <inheritdoc cref="IDisposable.Dispose"/>
-    public void Dispose()
+    public readonly void Dispose()
     {
         Array.Clear(this.array, 0, this.index);
 

src/CommunityToolkit.Mvvm/Messaging/Internals/System/Collections.Generic/Dictionary2.cs

@@ -320,7 +320,7 @@ public bool MoveNext()
         /// Gets the current key.
         /// </summary>
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public TKey GetKey()
+        public readonly TKey GetKey()
         {
             return this.entries[this.index - 1].Key;
         }
@@ -329,7 +329,7 @@ public TKey GetKey()
         /// Gets the current value.
         /// </summary>
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public TValue GetValue()
+        public readonly TValue GetValue()
         {
             return this.entries[this.index - 1].Value!;
         }

src/CommunityToolkit.Mvvm/Messaging/Internals/System/Runtime.CompilerServices/ConditionalWeakTable2{TKey,TValue}.Proxy.cs

@@ -72,13 +72,13 @@ public Enumerator(ConditionalWeakTable2<TKey, TValue> owner)
         }
 
         /// <inheritdoc cref="IDisposable.Dispose"/>
-        public void Dispose()
+        public readonly void Dispose()
         {
             this.enumerator.Dispose();
         }
 
         /// <inheritdoc cref="Collections.IEnumerator.MoveNext"/>
-        public bool MoveNext()
+        public readonly bool MoveNext()
         {
             return this.enumerator.MoveNext();
         }
@@ -87,7 +87,7 @@ public bool MoveNext()
         /// Gets the current key.
         /// </summary>
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public TKey GetKey()
+        public readonly TKey GetKey()
         {
             return this.enumerator.Current.Key;
         }
@@ -96,7 +96,7 @@ public TKey GetKey()
         /// Gets the current value.
         /// </summary>
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public TValue GetValue()
+        public readonly TValue GetValue()
         {
             return this.enumerator.Current.Value;
         }

src/CommunityToolkit.Mvvm/Messaging/Internals/System/Runtime.CompilerServices/ConditionalWeakTable2{TKey,TValue}.ZeroAlloc.cs

@@ -248,7 +248,7 @@ public bool MoveNext()
         /// Gets the current key.
         /// </summary>
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public TKey GetKey()
+        public readonly TKey GetKey()
         {
             return this.key!;
         }
@@ -257,7 +257,7 @@ public TKey GetKey()
         /// Gets the current value.
         /// </summary>
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public TValue GetValue()
+        public readonly TValue GetValue()
         {
             return this.value!;
         }

src/CommunityToolkit.Mvvm/Messaging/Internals/System/Runtime.CompilerServices/ConditionalWeakTable2{TKey,TValue}.cs

@@ -139,7 +139,7 @@ public Enumerator(ConditionalWeakTable2<TKey, TValue> owner)
         }
 
         /// <inheritdoc cref="IDisposable.Dispose"/>
-        public void Dispose()
+        public readonly void Dispose()
         {
         }
 
@@ -189,7 +189,7 @@ public bool MoveNext()
         /// Gets the current key.
         /// </summary>
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public TKey GetKey()
+        public readonly TKey GetKey()
         {
             return this.key!;
         }
@@ -198,7 +198,7 @@ public TKey GetKey()
         /// Gets the current value.
         /// </summary>
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public TValue GetValue()
+        public readonly TValue GetValue()
         {
             return this.value!;
         }

tests/CommunityToolkit.HighPerformance.UnitTests/Helpers/Test_ObjectMarshal.cs

@@ -70,7 +70,7 @@ internal struct TestStruct : IEquatable<TestStruct>
         public string Text;
 
         /// <inheritdoc/>
-        public bool Equals(TestStruct other)
+        public readonly bool Equals(TestStruct other)
         {
             return
                 this.Number == other.Number &&

tests/CommunityToolkit.HighPerformance.UnitTests/Test_Box{T}.cs

@@ -36,7 +36,7 @@ internal struct TestStruct : IEquatable<TestStruct>
         public string Text;
 
         /// <inheritdoc/>
-        public bool Equals(TestStruct other)
+        public readonly bool Equals(TestStruct other)
         {
             return
                 this.Number == other.Number &&