Update EXISTS to handle multiple keys

Fixes phpredis#1223

Author: michael-grunder

redis.c

@@ -1562,7 +1562,7 @@ PHP_METHOD(Redis, getMultiple)
  */
 PHP_METHOD(Redis, exists)
 {
-    REDIS_PROCESS_KW_CMD("EXISTS", redis_key_cmd, redis_1_response);
+    REDIS_PROCESS_CMD(exists, redis_long_response);
 }
 /* }}} */
 

redis_cluster.c

@@ -1008,7 +1008,7 @@ PHP_METHOD(RedisCluster, getset) {
 
 /* {{{ proto int RedisCluster::exists(string key) */
 PHP_METHOD(RedisCluster, exists) {
-    CLUSTER_PROCESS_KW_CMD("EXISTS", redis_key_cmd, cluster_1_resp, 1);
+    CLUSTER_PROCESS_CMD(exists, cluster_long_resp, 1);
 }
 /* }}} */
 

redis_commands.c

@@ -2790,6 +2790,14 @@ int redis_migrate_cmd(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock,
     return SUCCESS;
 }
 
+/* EXISTS */
+int redis_exists_cmd(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock,
+                     char **cmd, int *cmd_len, short *slot, void **ctx)
+{
+    return gen_varkey_cmd(INTERNAL_FUNCTION_PARAM_PASSTHRU, redis_sock,
+        "EXISTS", sizeof("EXISTS") - 1, 0, 0, cmd, cmd_len, slot);
+}
+
 /* DEL */
 int redis_del_cmd(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock,
                   char **cmd, int *cmd_len, short *slot, void **ctx)

redis_commands.h

@@ -201,6 +201,9 @@ int redis_object_cmd(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock,
     REDIS_REPLY_TYPE *rtype, char **cmd, int *cmd_len, short *slot,
     void **ctx);
 
+int redis_exists_cmd(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock,
+    char **cmd, int *cmd_len, short *slot, void **ctx);
+
 int redis_del_cmd(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock,
     char **cmd, int *cmd_len, short *slot, void **ctx);
 

tests/RedisArrayTest.php

@@ -460,8 +460,8 @@ public function testMultiExecDel() {
             ->exec();
 
         $this->assertTrue($out[0] === 2);
-        $this->assertTrue($this->ra->exists('1_{employee:joe}_group') === FALSE);
-        $this->assertTrue($this->ra->exists('1_{employee:joe}_salary') === FALSE);
+        $this->assertEquals(0, $this->ra->exists('1_{employee:joe}_group'));
+        $this->assertEquals(0, $this->ra->exists('1_{employee:joe}_salary'));
     }
 
     public function testDiscard() {

tests/RedisTest.php

@@ -354,7 +354,7 @@ public function testGetSet() {
     public function testRandomKey() {
         for($i = 0; $i < 1000; $i++) {
             $k = $this->redis->randomKey();
-            $this->assertTrue($this->redis->exists($k));
+            $this->assertEquals($this->redis->exists($k), 1);
         }
     }
 
@@ -555,7 +555,7 @@ public function testIncrByFloat()
         $this->redis->incrbyfloat('key',1.8);
         $this->assertEquals(1.8, floatval($this->redis->get('key'))); // convert to float to avoid rounding issue on arm
         $this->redis->setOption(Redis::OPT_PREFIX, '');
-        $this->assertTrue($this->redis->exists('someprefix:key'));
+        $this->assertEquals(1, $this->redis->exists('someprefix:key'));
         $this->redis->del('someprefix:key');
 
     }
@@ -586,10 +586,25 @@ public function testDecr()
 
     public function testExists()
     {
+        /* Single key */
         $this->redis->del('key');
-        $this->assertFalse($this->redis->exists('key'));
+        $this->assertEquals(0, $this->redis->exists('key'));
         $this->redis->set('key', 'val');
-        $this->assertEquals(True, $this->redis->exists('key'));
+        $this->assertEquals(1, $this->redis->exists('key'));
+
+        /* Add multiple keys */
+        $mkeys = [];
+        for ($i = 0; $i < 10; $i++) {
+            if (rand(1, 2) == 1) {
+                $mkey = "{exists}key:$i";
+                $this->redis->set($mkey, $i);
+                $mkeys[] = $mkey;
+            }
+        }
+
+        /* Test passing an array as well as the keys variadic */
+        $this->assertEquals(count($mkeys), $this->redis->exists($mkeys));
+        $this->assertEquals(count($mkeys), call_user_func_array([$this->redis, 'exists'], $mkeys));
     }
 
     public function testGetKeys()
@@ -4089,7 +4104,7 @@ private function checkSerializer($mode) {
         $this->redis->sAdd('k', 'a', 'b', 'c', 'd');
         $this->assertTrue(2 === $this->redis->sRem('k', 'a', 'd'));
         $this->assertTrue(2 === $this->redis->sRem('k', 'b', 'c', 'e'));
-        $this->assertTrue(FALSE === $this->redis->exists('k'));
+        $this->assertEquals(0, $this->redis->exists('k'));
 
         // sismember
         $this->assertTrue(TRUE === $this->redis->sismember('{set}key', $s[0]));