Findbugs and working with gradlew run

Bruce Eckel · Bruce Eckel · commit bb8b44564913 · 2017-05-01T17:43:21.000-06:00
diff --git a/annotations/AtUnitExample2.java b/annotations/AtUnitExample2.java
@@ -28,7 +28,8 @@ void assertFailureExample() {
   }
   @Test
   void exceptionExample() throws IOException {
-    new FileInputStream("nofile.txt"); // Throws
+    try(FileInputStream fis =
+        new FileInputStream("nofile.txt")) {} // Throws
   }
   @Test
   boolean assertAndReturn() {
diff --git a/annotations/UseCaseTracker.java b/annotations/UseCaseTracker.java
@@ -14,7 +14,7 @@ public class UseCaseTracker {
       if(uc != null) {
         System.out.println("Found Use Case " +
           uc.id() + "\n  " + uc.description());
-        useCases.remove(new Integer(uc.id()));
+        useCases.remove(Integer.valueOf(uc.id()));
       }
     }
     useCases.forEach(i ->
diff --git a/arrays/SimpleSetAll.java b/arrays/SimpleSetAll.java
@@ -14,7 +14,7 @@ class Bob {
 
 public class SimpleSetAll {
   public static final int SZ = 8;
-  public static int val = 1;
+  static int val = 1;
   static char[] chars = "abcdefghijklmnopqrstuvwxyz"
     .toCharArray();
   static char getChar(int n) { return chars[n]; }
diff --git a/collections/MapOfList.java b/collections/MapOfList.java
@@ -8,7 +8,7 @@
 import java.util.*;
 
 public class MapOfList {
-  public static Map<Person, List< ? extends Pet>>
+  public static final Map<Person, List< ? extends Pet>>
     petPeople = new HashMap<>();
   static {
     petPeople.put(new Person("Dawn"),
diff --git a/collectiontopics/CanonicalMapping.java b/collectiontopics/CanonicalMapping.java
@@ -39,7 +39,7 @@ public static void main(String[] args) {
     int size = 1000;
     // Or, choose size via the command line:
     if(args.length > 0)
-      size = new Integer(args[0]);
+      size = Integer.valueOf(args[0]);
     Key[] keys = new Key[size];
     WeakHashMap<Key,Value> map =
       new WeakHashMap<>();
diff --git a/collectiontopics/References.java b/collectiontopics/References.java
@@ -31,7 +31,7 @@ public static void main(String[] args) {
     int size = 10;
     // Or, choose size via the command line:
     if(args.length > 0)
-      size = new Integer(args[0]);
+      size = Integer.valueOf(args[0]);
     LinkedList<SoftReference<VeryBig>> sa =
       new LinkedList<>();
     for(int i = 0; i < size; i++) {
diff --git a/concurrent/CompletableOperations.java b/concurrent/CompletableOperations.java
@@ -9,7 +9,7 @@ public class CompletableOperations {
   static CompletableFuture<Integer> cfi(int i) {
     return
       CompletableFuture.completedFuture(
-        new Integer(i));
+        Integer.valueOf(i));
   }
   public static void main(String[] args) {
     showr(cfi(1)); // Basic test
diff --git a/concurrent/CountingTask.java b/concurrent/CountingTask.java
@@ -9,7 +9,7 @@ public class CountingTask implements Callable<Integer> {
   public CountingTask(int id) { this.id = id; }
   @Override
   public Integer call() {
-    Integer val = new Integer(0);
+    Integer val = 0;
     for(int i = 0; i < 100; i++)
       val++;
     System.out.println(id + " " +
diff --git a/concurrent/DiningPhilosophers.java b/concurrent/DiningPhilosophers.java
@@ -3,6 +3,7 @@
 // We make no guarantees that this code is fit for any purpose.
 // Visit http://OnJava8.com for more book information.
 // Hidden deadlock
+// {ValidateByHand} Gradle has trouble
 import java.util.*;
 import java.util.concurrent.*;
 import onjava.Nap;
diff --git a/concurrent/InterferingTask.java b/concurrent/InterferingTask.java
@@ -5,7 +5,7 @@
 
 public class InterferingTask implements Runnable {
   final int id;
-  private static Integer val = new Integer(0);
+  private static Integer val = 0;
   public InterferingTask(int id) { this.id = id; }
   @Override
   public void run() {
diff --git a/concurrent/ParallelStreamPuzzle2.java b/concurrent/ParallelStreamPuzzle2.java
@@ -10,7 +10,7 @@
 import java.nio.file.*;
 
 public class ParallelStreamPuzzle2 {
-  public static Deque<String> trace =
+  public static final Deque<String> trace =
     new ConcurrentLinkedDeque<>();
   static class
   IntGenerator implements Supplier<Integer> {
diff --git a/equalshashcode/Equality.java b/equalshashcode/Equality.java
@@ -46,7 +46,7 @@ public static void testAll(EqualityFactory eqf) {
       neq = eqf.make(99, "Bob", 1.618);
     e.test("null", "false", null);
     e.test("same object", "true", e);
-    e.test("different type", "false", new Integer(99));
+    e.test("different type", "false", Integer.valueOf(99));
     e.test("same values", "true", eq);
     e.test("different values", "false", neq);
   }
diff --git a/functional/Closure7.java b/functional/Closure7.java
@@ -7,7 +7,7 @@
 
 public class Closure7 {
   IntSupplier makeFun(int x) {
-    Integer i = new Integer(0);
+    Integer i = Integer.valueOf(0);
     i = i + 1;
     return () -> x + i;
   }
diff --git a/innerclasses/GreenhouseController.java b/innerclasses/GreenhouseController.java
@@ -24,7 +24,7 @@ gc.new ThermostatDay(1400)
     if(args.length == 1)
       gc.addEvent(
         new GreenhouseControls.Terminate(
-          new Integer(args[0])));
+          Integer.valueOf(args[0])));
     gc.run();
   }
 }
diff --git a/operators/EqualsMethod.java b/operators/EqualsMethod.java
@@ -5,8 +5,8 @@
 
 public class EqualsMethod {
   public static void main(String[] args) {
-    Integer n1 = new Integer(47);
-    Integer n2 = new Integer(47);
+    Integer n1 = 47;
+    Integer n2 = 47;
     System.out.println(n1.equals(n2));
   }
 }
diff --git a/operators/Equivalence.java b/operators/Equivalence.java
@@ -5,8 +5,8 @@
 
 public class Equivalence {
   public static void main(String[] args) {
-    Integer n1 = new Integer(47);
-    Integer n2 = new Integer(47);
+    Integer n1 = 47;
+    Integer n2 = 47;
     System.out.println(n1 == n2);
     System.out.println(n1 != n2);
   }
diff --git a/serialization/Blips.java b/serialization/Blips.java
@@ -6,7 +6,7 @@
 import java.io.*;
 
 class Blip1 implements Externalizable {
-  Blip1() {
+  public Blip1() {
     System.out.println("Blip1 Constructor");
   }
   @Override
diff --git a/serialization/FreezeAlien.java b/serialization/FreezeAlien.java
@@ -8,9 +8,12 @@
 public class FreezeAlien {
   public static void
   main(String[] args) throws Exception {
-    ObjectOutput out = new ObjectOutputStream(
-      new FileOutputStream("X.file"));
-    Alien quellek = new Alien();
-    out.writeObject(quellek);
+    try(
+      ObjectOutputStream out = new ObjectOutputStream(
+        new FileOutputStream("X.file"));
+    ) {
+      Alien quellek = new Alien();
+      out.writeObject(quellek);
+    }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,8 @@ void assertFailureExample() {`
`28`	`28`	`}`
`29`	`29`	`@Test`
`30`	`30`	`void exceptionExample() throws IOException {`
`31`		`- new FileInputStream("nofile.txt"); // Throws`
	`31`	`+ try(FileInputStream fis =`
	`32`	`+ new FileInputStream("nofile.txt")) {} // Throws`
`32`	`33`	`}`
`33`	`34`	`@Test`
`34`	`35`	`boolean assertAndReturn() {`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ public class UseCaseTracker {`
`14`	`14`	`if(uc != null) {`
`15`	`15`	`System.out.println("Found Use Case " +`
`16`	`16`	`uc.id() + "\n " + uc.description());`
`17`		`- useCases.remove(new Integer(uc.id()));`
	`17`	`+ useCases.remove(Integer.valueOf(uc.id()));`
`18`	`18`	`}`
`19`	`19`	`}`
`20`	`20`	`useCases.forEach(i ->`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ public class CompletableOperations {`
`9`	`9`	`static CompletableFuture<Integer> cfi(int i) {`
`10`	`10`	`return`
`11`	`11`	`CompletableFuture.completedFuture(`
`12`		`- new Integer(i));`
	`12`	`+ Integer.valueOf(i));`
`13`	`13`	`}`
`14`	`14`	`public static void main(String[] args) {`
`15`	`15`	`showr(cfi(1)); // Basic test`