Skip to content

Commit d9f0661

Browse files
committed
Fixes to filterSIgnal
1 parent d15f595 commit d9f0661

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"test-coverage": "ng test signal-generators --code-coverage true --watch false",
1313
"generate-coverage-badge": "npx istanbul-badges-readme --coverageDir=\"./coverage/signal-generators\"",
1414
"lint": "ng lint signal-generators",
15-
"patch-signal-generators-project": "git checkout --patch main projects/signal-generators"
15+
"patch-signal-generators-project": "git checkout --patch angular-signal-generators/main projects/signal-generators"
1616
},
1717
"private": true,
1818
"dependencies": {

projects/signal-generators/src/lib/generators/filter-signal.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,13 @@ function filterSignalFromValue<T, O extends T>(initialValue: O, filterFn: (x: T)
6666
const setFn = internal.set;
6767

6868
return Object.assign(internal, {
69-
set: (x: T) => setConditionally(setFn, x, filterFn),
70-
update: (signalUpdateFn: (x: T) => T) => setConditionally(setFn, signalUpdateFn(internal()), filterFn)
69+
set: (x: T) => setConditionally(x),
70+
update: (signalUpdateFn: (x: T) => T) => setConditionally(signalUpdateFn(internal()))
7171
});
7272

73-
function setConditionally<T, O extends T>(setter: (value: O) => void, value: T, filterFn: (x: T) => boolean): void {
73+
function setConditionally(value: T): void {
7474
if (filterFn(value)) {
75-
setter(value as O);
75+
setFn.call(internal, value as O);
7676
}
7777
}
7878
}

0 commit comments

Comments
 (0)