From 8b52fd9b753d5811af7e6b441cd4aca7fc27468b Mon Sep 17 00:00:00 2001 From: Raoul Zwart Date: Sun, 7 Aug 2011 10:59:00 +0200 Subject: [PATCH 1/2] Also accept a string as the offset in filter specification. The old behaviour, when passed e.g. the string '13', was to return 0. This resulted in an filterfld error from the server. String will now be converted to int by Perl. --- perl-Net-HandlerSocket/HandlerSocket.xs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/perl-Net-HandlerSocket/HandlerSocket.xs b/perl-Net-HandlerSocket/HandlerSocket.xs index 39f11e2..39700e2 100644 --- a/perl-Net-HandlerSocket/HandlerSocket.xs +++ b/perl-Net-HandlerSocket/HandlerSocket.xs @@ -146,7 +146,7 @@ sv_get_string_ref(SV *sv) static IV sv_get_iv(SV *sv) { - if (sv == 0 || !SvIOK(sv)) { + if (sv == 0 || !SvIOK(sv) || !SvPOK(sv)) { return 0; } return SvIV(sv); From 64aa24849988c2e69b59593e0763b4c4e79b2617 Mon Sep 17 00:00:00 2001 From: Raoul Zwart Date: Sun, 7 Aug 2011 11:12:08 +0200 Subject: [PATCH 2/2] Fix: accept _both_ numbers and strings as offset parameter in filter specification. --- perl-Net-HandlerSocket/HandlerSocket.xs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/perl-Net-HandlerSocket/HandlerSocket.xs b/perl-Net-HandlerSocket/HandlerSocket.xs index 39700e2..d0aaaa3 100644 --- a/perl-Net-HandlerSocket/HandlerSocket.xs +++ b/perl-Net-HandlerSocket/HandlerSocket.xs @@ -146,7 +146,7 @@ sv_get_string_ref(SV *sv) static IV sv_get_iv(SV *sv) { - if (sv == 0 || !SvIOK(sv) || !SvPOK(sv)) { + if (sv == 0 || ( !SvIOK(sv) && !SvPOK(sv) ) ) { return 0; } return SvIV(sv);