Skip to content

Commit 47b8415

Browse files
committed
Merge branch 'master' of git://github.com/rails/rails
2 parents 6d772c0 + e746c40 commit 47b8415

File tree

177 files changed

+2490
-1815
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

177 files changed

+2490
-1815
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,5 @@ railties/doc
2121
railties/guides/output
2222
railties/tmp
2323
.rvmrc
24+
.rbenv-version
2425
RDOC_MAIN.rdoc

.travis.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ script: 'ci/travis.rb'
22
rvm:
33
- 1.8.7
44
- 1.9.2
5+
- 1.9.3
56
env:
67
- "GEM=railties"
78
- "GEM=ap,am,amo,ares,as"
@@ -11,4 +12,5 @@ env:
1112
notifications:
1213
email: false
1314
irc:
14-
- "irc.freenode.org#rails-contrib"
15+
- "irc.freenode.org#rails-contrib"
16+
bundler_args: --path vendor/bundle

Gemfile

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,17 @@ gem "jquery-rails"
1111
# it being automatically loaded by sprockets
1212
gem "uglifier", ">= 1.0.0", :require => false
1313

14-
gem "rake", ">= 0.8.7"
14+
# Temp fix until rake 0.9.3 is out
15+
if RUBY_VERSION >= "1.9.3"
16+
gem "rake", "0.9.3.beta.1"
17+
else
18+
gem "rake", ">= 0.8.7"
19+
end
1520
gem "mocha", ">= 0.9.8"
1621

1722
group :doc do
1823
gem "rdoc", "~> 3.4"
19-
gem "horo", "= 1.0.3"
24+
gem "sdoc", "~> 0.3"
2025
gem "RedCloth", "~> 4.2" if RUBY_VERSION < "1.9.3"
2126
gem "w3c_validators"
2227
end

README.rdoc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,28 +8,28 @@ into three layers, each with a specific responsibility.
88

99
The View layer is composed of "templates" that are responsible for providing
1010
appropriate representations of your application's resources. Templates
11-
can come in a variety of formats, but most view templates are HTML with embedded Ruby
11+
can come in a variety of formats, but most view templates are \HTML with embedded Ruby
1212
code (.erb files).
1313

1414
The Model layer represents your domain model (such as Account, Product, Person, Post)
1515
and encapsulates the business logic that is specific to your application. In Rails,
16-
database-backed model classes are derived from ActiveRecord::Base. ActiveRecord allows
16+
database-backed model classes are derived from ActiveRecord::Base. Active Record allows
1717
you to present the data from database rows as objects and embellish these data objects
1818
with business logic methods. Although most Rails models are backed by a database, models
1919
can also be ordinary Ruby classes, or Ruby classes that implement a set of interfaces as
2020
provided by the ActiveModel module. You can read more about Active Record in its
21-
{README}[link:blob/master/activerecord/README.rdoc].
21+
{README}[link:/rails/rails/blob/master/activerecord/README.rdoc].
2222

2323
The Controller layer is responsible for handling incoming HTTP requests and providing a
24-
suitable response. Usually this means returning HTML, but Rails controllers can also
24+
suitable response. Usually this means returning \HTML, but Rails controllers can also
2525
generate XML, JSON, PDFs, mobile-specific views, and more. Controllers manipulate models
2626
and render view templates in order to generate the appropriate HTTP response.
2727

2828
In Rails, the Controller and View layers are handled together by Action Pack.
2929
These two layers are bundled in a single package due to their heavy interdependence.
3030
This is unlike the relationship between Active Record and Action Pack which are
3131
independent. Each of these packages can be used independently outside of Rails. You
32-
can read more about Action Pack in its {README}[link:blob/master/actionpack/README.rdoc].
32+
can read more about Action Pack in its {README}[link:/rails/rails/blob/master/actionpack/README.rdoc].
3333

3434
== Getting Started
3535

@@ -62,7 +62,7 @@ can read more about Action Pack in its {README}[link:blob/master/actionpack/READ
6262
* The {API Documentation}[http://api.rubyonrails.org].
6363

6464

65-
== Contributing
65+
== Contributing http://travis-ci.org/rails/rails.png
6666

6767
We encourage you to contribute to Ruby on Rails! Please check out the {Contributing to Rails
6868
guide}[http://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html] for guidelines about how

RELEASING_RAILS.rdoc

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -145,18 +145,25 @@ commits should be added to the release branch besides regression fixing commits.
145145
Many of these steps are the same as for the release candidate, so if you need
146146
more explanation on a particular step, so the RC steps.
147147

148-
=== Email the rails security announce list, once for each vulnerability fixed.
149-
150-
You can do this, or ask the security team to do it.
151-
152-
FIXME: I can't remember the email addresses, but we should list them here.
153-
FIXME: Possibly we should do this the day of the RC?
148+
Today, do this stuff in this order:
154149

155150
* Apply security patches to the release branch
156151
* Update CHANGELOG with security fixes.
157152
* Update RAILS_VERSION to remove the rc
158153
* Release the gems
159-
* Email announcement
154+
* Email security lists
155+
* Email general announcement lists
156+
157+
=== Emailing the rails security announce list
158+
159+
Email the security announce list once for each vulnerability fixed.
160+
161+
You can do this, or ask the security team to do it.
162+
163+
Email the security reports to:
164+
165+
166+
160167

161168
Be sure to note the security fixes in your announcement along with CVE numbers
162169
and links to each patch. Some people may not be able to upgrade right away,

Rakefile

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#!/usr/bin/env rake
22

33
require 'rdoc/task'
4+
require 'sdoc'
45
require 'net/http'
56

67
$:.unshift File.expand_path('..', __FILE__)
@@ -74,7 +75,10 @@ RDoc::Task.new do |rdoc|
7475
# since no autolinking happens there and RDoc displays the backslash
7576
# otherwise.
7677
rdoc_main.gsub!(/^(?=\S).*?\b(?=Rails)\b/) { "#$&\\" }
77-
rdoc_main.gsub!(%r{link:blob/master/(\w+)/README\.rdoc}, "link:files/\\1/README_rdoc.html")
78+
rdoc_main.gsub!(%r{link:/rails/rails/blob/master/(\w+)/README\.rdoc}, "link:files/\\1/README_rdoc.html")
79+
80+
# Remove Travis build status image from API pages. Only GitHub README page gets this image
81+
rdoc_main.gsub!("http://travis-ci.org/rails/rails.png", "")
7882

7983
File.open(RDOC_MAIN, 'w') do |f|
8084
f.write(rdoc_main)
@@ -86,8 +90,10 @@ RDoc::Task.new do |rdoc|
8690
rdoc.rdoc_dir = 'doc/rdoc'
8791
rdoc.title = "Ruby on Rails Documentation"
8892

89-
rdoc.options << '-f' << 'horo'
93+
rdoc.options << '-f' << 'sdoc'
94+
rdoc.options << '-T' << 'rails'
9095
rdoc.options << '-c' << 'utf-8'
96+
rdoc.options << '-g' # SDoc flag, link methods to GitHub
9197
rdoc.options << '-m' << RDOC_MAIN
9298

9399
rdoc.rdoc_files.include('railties/CHANGELOG')

actionpack/CHANGELOG

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@
3030

3131
*Rails 3.1.0 (unreleased)*
3232

33+
* Param values are `paramified` in controller tests. [David Chelimsky]
34+
35+
* x_sendfile_header now defaults to nil and config/environments/production.rb doesn't set a particular value for it. This allows servers to set it through X-Sendfile-Type. [Santiago Pastorino]
36+
3337
* The submit form helper does not generate an id "object_name_id" anymore. [fbrusatti]
3438

3539
* Make sure respond_with with :js tries to render a template in all cases [José Valim]

actionpack/actionpack.gemspec

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,13 @@ Gem::Specification.new do |s|
1818

1919
s.add_dependency('activesupport', version)
2020
s.add_dependency('activemodel', version)
21-
s.add_dependency('rack-cache', '~> 1.0.2')
21+
s.add_dependency('rack-cache', '~> 1.0.3')
2222
s.add_dependency('builder', '~> 3.0.0')
2323
s.add_dependency('i18n', '~> 0.6')
2424
s.add_dependency('rack', '~> 1.3.2')
25-
s.add_dependency('rack-test', '~> 0.6.0')
26-
s.add_dependency('rack-mount', '~> 0.8.1')
27-
s.add_dependency('sprockets', '~> 2.0.0.beta.12')
25+
s.add_dependency('rack-test', '~> 0.6.1')
26+
s.add_dependency('rack-mount', '~> 0.8.2')
27+
s.add_dependency('sprockets', '~> 2.0.0')
2828
s.add_dependency('erubis', '~> 2.7.0')
2929

3030
s.add_development_dependency('tzinfo', '~> 0.3.29')

actionpack/lib/abstract_controller/view_paths.rb

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
require 'action_view/base'
2+
13
module AbstractController
24
module ViewPaths
35
extend ActiveSupport::Concern
@@ -63,7 +65,7 @@ module ClassMethods
6365
# the default view path. You may also provide a custom view path
6466
# (see ActionView::PathSet for more information)
6567
def append_view_path(path)
66-
self.view_paths = view_paths.dup + Array(path)
68+
self._view_paths = view_paths + Array(path)
6769
end
6870

6971
# Prepend a path to the list of view paths for this controller.
@@ -73,7 +75,7 @@ def append_view_path(path)
7375
# the default view path. You may also provide a custom view path
7476
# (see ActionView::PathSet for more information)
7577
def prepend_view_path(path)
76-
self.view_paths = Array(path) + view_paths.dup
78+
self._view_paths = ActionView::PathSet.new(Array(path) + view_paths)
7779
end
7880

7981
# A list of all of the default view paths for this controller.
@@ -87,8 +89,7 @@ def view_paths
8789
# * <tt>paths</tt> - If a PathSet is provided, use that;
8890
# otherwise, process the parameter into a PathSet.
8991
def view_paths=(paths)
90-
self._view_paths = ActionView::Base.process_view_paths(paths)
91-
self._view_paths.freeze
92+
self._view_paths = ActionView::PathSet.new(Array.wrap(paths))
9293
end
9394
end
9495
end

actionpack/lib/action_controller/base.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ module ActionController
6363
#
6464
# == Sessions
6565
#
66-
# Sessions allows you to store objects in between requests. This is useful for objects that are not yet ready to be persisted,
66+
# Sessions allow you to store objects in between requests. This is useful for objects that are not yet ready to be persisted,
6767
# such as a Signup object constructed in a multi-paged process, or objects that don't change much and are needed all the time, such
6868
# as a User object for a system that requires login. The session should not be used, however, as a cache for objects where it's likely
6969
# they could be changed unknowingly. It's usually too much work to keep it all synchronized -- something databases already excel at.

0 commit comments

Comments
 (0)