Skip to content

Commit c28b5fe

Browse files
committed
chore(build): 1.0.6 closes PatrickJS#12
1 parent c9ba659 commit c28b5fe

9 files changed

+51
-13
lines changed

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
## 1.0.6 (2015-1-7)
2+
3+
Features:
4+
- Include onErrorCallbacks docs
5+
- Include onCloseCallbacks docs
6+
7+
Bugfixes:
8+
- Typo in _connect()
9+
110
## 1.0.5 (2014-12-29)
211

312
Features:

angular-websocket.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
(function() {
2+
'use strict';
23

34
var noop = function() {};
45
var objectFreeze = (Object.freeze) ? Object.freeze : noop;
56
var objectDefineProperty = Object.defineProperty;
67
var isString = angular.isString;
78
var isFunction = angular.isFunction;
89
var isDefined = angular.isDefined;
10+
var arraySlice = Array.prototype.slice;
911
var isArray = angular.isArray;
1012
// ie8 wat
1113
if (!Array.prototype.indexOf) {
@@ -31,20 +33,20 @@
3133
// internal IsCallable function
3234
throw new TypeError('Function.prototype.bind - what is trying to be bound is not callable');
3335
}
34-
35-
var aArgs = Array.prototype.slice.call(arguments, 1),
36+
37+
var aArgs = arraySlice.call(arguments, 1),
3638
fToBind = this,
3739
fNOP = function() {},
3840
fBound = function() {
3941
return fToBind.apply(this instanceof fNOP && oThis
4042
? this
4143
: oThis,
42-
aArgs.concat(Array.prototype.slice.call(arguments)));
44+
aArgs.concat(arraySlice.call(arguments)));
4345
};
44-
46+
4547
fNOP.prototype = this.prototype;
4648
fBound.prototype = new fNOP();
47-
49+
4850
return fBound;
4951
};
5052
}
@@ -115,7 +117,7 @@
115117

116118
$WebSocket.prototype._connect = function (force) {
117119
if (force || !this.socket || this.socket.readyState !== this._readyStateConstants.OPEN) {
118-
this.socket = $websocketBackend.createWebSocketBackend(this.url, this.protocol);
120+
this.socket = $websocketBackend.createWebSocketBackend(this.url, this.protocols);
119121
this.socket.onopen = this._onOpenHandler.bind(this);
120122
this.socket.onmessage = this._onMessageHandler.bind(this);
121123
this.socket.onerror = this._onErrorHandler.bind(this);

angular-websocket.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)