Delegate commands to Expo CLI (expo#751)

* Delegate commands to Expo CLI

* Add a deprecation warning and upgrade instructions.

* Remove now unnecessary dependencies

Author: fson

create-react-native-app/src/index.js

@@ -86,6 +86,14 @@ async function createApp(name: string, verbose: boolean, version: ?string): Prom
 
   const packageToInstall = getInstallPackage(version);
   const packageName = getPackageName(packageToInstall);
+
+  if (packageToInstall === 'react-native-scripts') {
+    // The latest version of react-native-scripts is just a wrapper for expo-cli,
+    // so we can skip installing it and just run expo-cli directly.
+    runExpoCli('init', name);
+    return;
+  }
+
   checkAppName(appName, packageName);
 
   if (!await pathExists(name)) {
@@ -275,3 +283,37 @@ async function isSafeToCreateProjectIn(root: string): Promise<boolean> {
     return validFiles.indexOf(file) >= 0;
   });
 }
+
+function runExpoCli(...args) {
+  spawn('expo-cli', args, { stdio: 'inherit' })
+    .on('exit', function(code) {
+      process.exit(code);
+    })
+    .on('error', function() {
+      console.warn('This command requires Expo CLI.');
+      var rl = require('readline').createInterface({
+        input: process.stdin,
+        output: process.stdout,
+      });
+      rl.question('Do you want to install it globally [Y/n]? ', function(answer) {
+        rl.close();
+        if (/^n/i.test(answer.trim())) {
+          process.exit(1);
+        } else {
+          console.log("Installing the package 'expo-cli'...");
+          spawn('npm', ['install', '--global', '--loglevel', 'error', 'expo-cli@latest'], {
+            stdio: ['inherit', 'ignore', 'inherit'],
+          }).on('close', function(code) {
+            if (code !== 0) {
+              console.error('Installing Expo CLI failed. You can install it manually with:');
+              console.error('  npm install --global expo-cli');
+              process.exit(code);
+            } else {
+              console.log('Expo CLI installed. You can run `expo --help` for instructions.');
+              runExpoCli(...args);
+            }
+          });
+        }
+      });
+    });
+}

react-native-scripts/__mocks__/fs.js

@@ -25,21 +25,10 @@
     "build": "taskr build"
   },
   "dependencies": {
-    "@expo/bunyan": "1.8.10",
     "babel-runtime": "^6.9.2",
     "chalk": "^2.0.1",
     "cross-spawn": "^5.0.1",
-    "fs-extra": "^3.0.1",
-    "indent-string": "^3.0.0",
-    "inquirer": "^3.0.1",
-    "lodash": "^4.17.4",
-    "match-require": "^2.0.0",
-    "minimist": "^1.2.0",
-    "path-exists": "^3.0.0",
-    "progress": "^2.0.0",
-    "qrcode-terminal": "^0.11.0",
-    "rimraf": "^2.6.1",
-    "xdl": "48.1.4"
+    "minimist": "^1.2.0"
   },
   "devDependencies": {
     "@taskr/babel": "^1.0.6",

react-native-scripts/package.json

@@ -1,22 +1,77 @@
 #!/usr/bin/env node
-// @flow
+'use strict';
 import spawn from 'cross-spawn';
+import chalk from 'chalk';
 
 const script = process.argv[2];
 const args = process.argv.slice(3);
 
-const validCommands = ['eject', 'android', 'ios', 'start', 'test'];
-
-if (validCommands.indexOf(script) !== -1) {
-  // the command is valid
-  const result = spawn.sync(
-    'node',
-    ['--no-deprecation', require.resolve('../scripts/' + script)].concat(args),
-    { stdio: 'inherit' }
-  );
-  process.exit(result.status);
+if (script === 'start' || script === 'eject') {
+  printDeprecationMessage();
+  runExpoCli(script, ...args);
+} else if (script === 'android' || script === 'ios') {
+  printDeprecationMessage();
+  runExpoCli('start', `--${script}`, ...args);
 } else {
   console.log(
     `Invalid command '${script}'. Please check if you need to update react-native-scripts.`
   );
+  process.exit(1);
+}
+
+function printDeprecationMessage() {
+  console.warn(chalk.bold('Note: react-native-scripts is deprecated.\n'));
+  console.warn(chalk.underline('Upgrading your project to use Expo CLI:\n'));
+  console.warn('Make these changes to package.json:');
+  console.warn(
+    chalk.bold("1) Replace 'react-native-scripts' with 'expo' in the 'scripts' config.")
+  );
+  console.warn(
+    `   Example:
+    "scripts": {
+      "start": "expo start",
+      "eject": "expo eject",
+      "android": "expo start --android",
+      "ios": "expo start --ios",
+      "test": "jest"
+    }`
+  );
+  console.warn(chalk.bold('2) Remove react-native-scripts from devDependencies.\n'));
+  console.warn(
+    chalk.bold("That's all! Expo CLI will install automatically when you run `npm start`.\n")
+  );
+}
+
+function runExpoCli(...args) {
+  spawn('expo-cli', args, { stdio: 'inherit' })
+    .on('exit', function(code) {
+      process.exit(code);
+    })
+    .on('error', function() {
+      console.warn('This command requires Expo CLI.');
+      var rl = require('readline').createInterface({
+        input: process.stdin,
+        output: process.stdout,
+      });
+      rl.question('Do you want to install it globally [Y/n]? ', function(answer) {
+        rl.close();
+        if (/^n/i.test(answer.trim())) {
+          process.exit(1);
+        } else {
+          console.log("Installing the package 'expo-cli'...");
+          spawn('npm', ['install', '--global', '--loglevel', 'error', 'expo-cli@latest'], {
+            stdio: ['inherit', 'ignore', 'inherit'],
+          }).on('close', function(code) {
+            if (code !== 0) {
+              console.error('Installing Expo CLI failed. You can install it manually with:');
+              console.error('  npm install --global expo-cli');
+              process.exit(code);
+            } else {
+              console.log('Expo CLI installed. You can run `expo --help` for instructions.');
+              runExpoCli(...args);
+            }
+          });
+        }
+      });
+    });
 }