Skip to content

Commit 1b72352

Browse files
committed
= improve scripts
- use `$*` in string instead of `$@` - improve comments
1 parent f411b65 commit 1b72352

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

bin/find-in-jars

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ while (($# > 0)); do
189189
use_absolute_path=true
190190
shift
191191
;;
192-
# support the typo option name --seperator for compatibility
192+
# support the legacy typo option name --seperator for compatibility
193193
-s | --separator | --seperator)
194194
separator="$2"
195195
shift 2

bin/show-busy-java-threads

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -246,12 +246,12 @@ while true; do
246246
store_dir="$2"
247247
shift 2
248248
;;
249-
# support the option name -P,--use-ps for compatibility
249+
# support the legacy option name -P,--use-ps for compatibility
250250
-P | --use-ps)
251251
cpu_sample_interval=0
252252
shift
253253
;;
254-
# support the option name -d,--top-delay for compatibility
254+
# support the legacy option name -d,--top-delay for compatibility
255255
-i | --cpu-sample-interval | -d | --top-delay)
256256
cpu_sample_interval="$2"
257257
shift 2
@@ -420,7 +420,7 @@ findBusyJavaThreadsByPs() {
420420
[ -n "$ps_out" ] || __die_when_no_java_process_found
421421

422422
if [ -n "$store_dir" ]; then
423-
echo "$ps_out" | logAndCat "${ps_cmd_line[@]} | sort -k3,3nr" >"${store_file_prefix}$((update_round_num + 1))_ps"
423+
echo "$ps_out" | logAndCat "${ps_cmd_line[*]} | sort -k3,3nr" >"${store_file_prefix}$((update_round_num + 1))_ps"
424424
fi
425425

426426
if ((count > 0)); then

0 commit comments

Comments
 (0)