Skip to content

Commit f5d3862

Browse files
committed
! show-duplicate-java-classes: improve sort in print_duplicate_classes_info
sort multiple keys by one trip
1 parent 0e172ed commit f5d3862

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

bin/show-duplicate-java-classes

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -240,8 +240,9 @@ def print_duplicate_classes_info(class_paths_to_duplicate_classes):
240240
# https://stackoverflow.com/questions/1143671
241241
# Sort a list by multiple attributes?
242242
# https://stackoverflow.com/questions/4233476
243-
class_paths_to_duplicate_classes.sort(key=lambda item: item[0])
244-
class_paths_to_duplicate_classes.sort(reverse=True, key=lambda item: (len(item[0]), len(item[1])))
243+
#
244+
# use - operator of number key for reverse sort key
245+
class_paths_to_duplicate_classes.sort(key=lambda item: (-len(item[0]), -len(item[1]), item[0]))
245246

246247
idx_str_max_len = len(str(len(class_paths_to_duplicate_classes)))
247248
for idx, (class_paths, classes) in enumerate(class_paths_to_duplicate_classes, start=1):

0 commit comments

Comments
 (0)