Skip to content

feat: expect NSString token instead NSData #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

feat: expect NSString token instead NSData #1

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
dffaa85
fix(ios): edge case when non-interactive notification is tapped
mvayngrib Apr 3, 2019
ec2d6d7
fix: mis-emission of notification opened event
mvayngrib Apr 3, 2019
8066938
fix: propagate error when user denies permission
mvayngrib Apr 4, 2019
3edca5f
rename to publish under @exodus in npm
mvayngrib Apr 4, 2019
b29368e
1.3.1
mvayngrib Apr 4, 2019
1e9dfc4
fix: specify requiresMainQueueSetup -> YES, to remove annoying warning
mvayngrib Apr 4, 2019
83ea4c6
1.3.2
mvayngrib Apr 4, 2019
f5a3011
feat: support requesting local-only notifications
mvayngrib Apr 5, 2019
6b53f9d
1.4.0
mvayngrib Apr 5, 2019
c959e8a
fix: default requestPermissions to remote:true
mvayngrib Apr 5, 2019
96fdfba
1.4.1
mvayngrib Apr 5, 2019
1d144e8
fix: use RCTConvert to interpret options
mvayngrib Apr 5, 2019
c35a2e8
1.4.2
mvayngrib Apr 5, 2019
c11cd6b
feat: expect NSString token instead NSData
diegomura Jun 14, 2021
0146cae
fix: add tabs back to RNNRouter.m
diegomura Jun 14, 2021
66d2fd9
fix: add tabs back to RNNRouter.m
diegomura Jun 14, 2021
bf29ea8
fix: add tabs back to RNNotifications.m
diegomura Jun 14, 2021
b93646c
fix: add tabs back to RNNotifications.m
diegomura Jun 14, 2021
1201a22
fix: add tabs back to AppDelegate.m
diegomura Jun 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: expect NSString token instead NSData
  • Loading branch information
@diegomura
diegomura committed Jun 14, 2021
commit c11cd6b0765ed03b65a970a56fd972d285bf0c52
4 changes: 2 additions & 2 deletions RNNotifications/RNNRouter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@


@protocol RNNRerouterDelegate <NSObject>
- (void)application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken;
- (void)application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSString *)deviceToken;
- (void)application:(UIApplication *)application didFailToRegisterForRemoteNotificationsWithError:(NSError *)error;
- (void)application:(UIApplication *)application didReceiveRemoteNotification:(NSDictionary *)userInfo fetchCompletionHandler:(void (^)(UIBackgroundFetchResult))completionHandler;
- (void)userNotificationCenter:(UNUserNotificationCenter *)center willPresentNotification:(UNNotification *)notification withCompletionHandler:(void (^)(UNNotificationPresentationOptions))completionHandler;
Expand All @@ -27,7 +27,7 @@

@property (nonatomic, weak) id <RNNRerouterDelegate> _Nullable delegate;

- (void)application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken;
- (void)application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSString *)deviceToken;
- (void)application:(UIApplication *)application didFailToRegisterForRemoteNotificationsWithError:(NSError *)error;
- (void)application:(UIApplication *)application didReceiveRemoteNotification:(NSDictionary *)userInfo fetchCompletionHandler:(nullable void (^)(UIBackgroundFetchResult))completionHandler;
- (void)didUpdatePushCredentials:(PKPushCredentials *)credentials forType:(NSString *)type;
Expand Down
14 changes: 7 additions & 7 deletions RNNotifications/RNNRouter.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ - (instancetype)init
if(self)
{
_pendingDelegateCalls = [NSMutableArray new];

}
return self;
}
Expand All @@ -48,15 +48,15 @@ - (instancetype)init
- (void)setDelegate:(id<RNNRerouterDelegate,UNUserNotificationCenterDelegate>)delegate
{
_delegate = delegate;

while (self.pendingDelegateCalls.count > 0)
{
void(^block)(void) = _pendingDelegateCalls.lastObject;
block();
[_pendingDelegateCalls removeLastObject];
}


}


Expand All @@ -78,7 +78,7 @@ - (void)userNotificationCenter:(UNUserNotificationCenter *)center willPresentNot
void(^callLaterBlock)(void) = ^{
[self->_delegate userNotificationCenter:center willPresentNotification:notification withCompletionHandler:completionHandler];
};

if(_delegate)
{
callLaterBlock();
Expand All @@ -94,7 +94,7 @@ - (void)userNotificationCenter:(UNUserNotificationCenter *)center didReceiveNoti
void(^callLaterBlock)(void) = ^{
[self->_delegate userNotificationCenter:center didReceiveNotificationResponse:response withCompletionHandler:completionHandler];
};

if(_delegate)
{
callLaterBlock();
Expand All @@ -105,7 +105,7 @@ - (void)userNotificationCenter:(UNUserNotificationCenter *)center didReceiveNoti
}
}

- (void)application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken
- (void)application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSString *)deviceToken
{
if (self.delegate != nil)
{
Expand Down
Loading