[HOLD for payment 2023-09-29] [$1000] Android - Login - Linkified email from external app is pasted as linkified email in email field

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Copy a linkified email address from external app (like gmail).
2. Launch New Expensify app.
3. Long tap on the email field.
4. Select Paste.

Expected Result:

Email is not linkified

Actual Result:

Email is linkified

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.31.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6103773_Screen_Recording_20230623_181250_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fec00bf5a9d050cf
• Upwork Job ID: 1673491584987435008
• Last Price Increase: 2023-06-27

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[cubuspl42]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When pasting rich text to the e-mail field, the formatting is preserved, although we'd like the text to be plain text.

What is the root cause of that problem?

On Android, TextInput for some reason is rich text input by default. It can contain initial formatted text, for example:

<TextInput>
    Hello, <Text style={{color:'red'}}>World</Text>
</TextInput>

Also, formatted text can be pasted by the user.

What changes do you think we should make in order to solve the problem?

Surprisingly, there is no way to disable the rich text properties of the TextInput.

There is a workaround, though. One can heuristically detect when the text is pasted and change it to some other text (so the internal formatting markers are cleared), but immediately change it back.

We could introduce these helpers:

const zeroWidthSpace = '\u8203';

/**
 * A very simple heuristic for detecting whether the text was pasted
 *
 * @param {String} oldText
 * @param {String} newText
 * @return {Boolean}
 */
function isTextPasted(oldText, newText) {
    return Math.abs(newText.length - oldText.length) > 1;
}

/**
 * A helper for setting a TextInput-managed state, which ensures that the
 * text keeps being plain, even when formatted text is pasted by the user.
 *
 * @param {Object} component
 * @param {Function} buildState
 * @param {String} oldText
 * @param {String} newText
 */
function setPlainTextInputState(component, buildState, oldText, newText) {
    if (isTextPasted(oldText, newText)) {
        // Set a similar but different text, so TextInput clears formatting markers
        component.setState(buildState(
            `${zeroWidthSpace}${newText}${zeroWidthSpace}`,
        ), () => {
            // Change back to the pasted text (in the plain text)
            component.setState(buildState(newText));
        });
    } else {
        // If it doesn't look like a paste, set the state directly to minimize flickering
        component.setState(buildState(newText));
    }
}

And then use them in LoginForm's onTextInput method:

    /**
     * Handle text input and clear formError upon text change
     *
     * @param {String} newText
     */
    onTextInput(newText) {
        setPlainTextInputState(
            this,
            (text) => ({login: text}),
            this.state.login,
            newText,
        );

        this.setState({
            formError: null,
        });

        // ...
    }

[Christinadobrzyn]

I'm not able to replicate this - reaching out in Slack to get more specific directions on how the email is copied.

[cubuspl42]

@Christinadobrzyn

You can copy any link, for what it's worth. Let's say from here. When I copied from Chrome, I had to use text selection.

RichText-1-compressed.mp4

[Christinadobrzyn]

I might not be able to get this to work on Browserstack but it seems like enough people can reproduce it so I'll send it to External.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fec00bf5a9d050cf