Skip to content

Commit 96425e2

Browse files
committed
fix: task run
1 parent d78b135 commit 96425e2

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

src/pages/background/tasks/core.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export async function runTask(task: Task) {
7373
logger.debug('[task] runTask success', task, taskRes);
7474
result.status = 'done';
7575
result.result = taskRes;
76-
validTaskRun[task.key] = taskRes;
76+
validTaskRun[task.key] = result;
7777
emitter.emit(emitter.INNER_TASK_RUN, task, result);
7878
return result;
7979
};
@@ -102,11 +102,10 @@ export async function runTask(task: Task) {
102102
body: task.fetch.body,
103103
});
104104
let taskRes: any;
105-
if (task.fetch.responseType === 'text') {
106-
taskRes = await res.text();
107-
}
108105
if (task.fetch.responseType === 'json') {
109106
taskRes = await res.json();
107+
} else {
108+
taskRes = await res.text();
110109
}
111110
const validator = task.fetch.validator;
112111
if (validator) {
@@ -140,7 +139,6 @@ export async function runTaskAndSave(task: Task) {
140139
try {
141140
result = await runTask(task);
142141
if (result.status === 'done') {
143-
validTaskRun[task.key] = result;
144142
break;
145143
}
146144
} catch (e) {

tests/e2e/task.spec.mjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ describe('Run task', () =>
1818
fetch: {
1919
url: `${testServer}mock-json.php?value=${value}`,
2020
method: 'GET',
21+
responseType: 'json',
2122
},
2223
});
2324

0 commit comments

Comments
 (0)