Skip to content

Commit df6b4b4

Browse files
ScottChao-WistronCommit Bot
authored andcommitted
gimble: remove obsolete C1 reset configuration
This problem was fixed by PS8815 FW version 0x3. And we are now using 0x25. BUG=b:223315425 TEST=Check with Parade Signed-off-by: Scott Chao <[email protected]> Change-Id: Ifc554ed750b1e886efe741396f6cf45bc13a1e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3533299 Tested-by: Peter Chi <[email protected]> Reviewed-by: Boris Mittelberg <[email protected]>
1 parent 57b31e7 commit df6b4b4

File tree

1 file changed

+1
-24
lines changed

1 file changed

+1
-24
lines changed

board/gimble/usbc_config.c

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -151,25 +151,6 @@ void config_usb_db_type(void)
151151
CPRINTS("Configured USB DB type number is %d", db_type);
152152
}
153153

154-
static void ps8815_reset(void)
155-
{
156-
int val;
157-
158-
CPRINTS("%s: patching ps8815 registers", __func__);
159-
160-
if (i2c_read8(I2C_PORT_USB_C1_TCPC,
161-
PS8XXX_I2C_ADDR1_P2_FLAGS, 0x0f, &val) == EC_SUCCESS)
162-
CPRINTS("ps8815: reg 0x0f was %02x", val);
163-
164-
if (i2c_write8(I2C_PORT_USB_C1_TCPC,
165-
PS8XXX_I2C_ADDR1_P2_FLAGS, 0x0f, 0x31) == EC_SUCCESS)
166-
CPRINTS("ps8815: reg 0x0f set to 0x31");
167-
168-
if (i2c_read8(I2C_PORT_USB_C1_TCPC,
169-
PS8XXX_I2C_ADDR1_P2_FLAGS, 0x0f, &val) == EC_SUCCESS)
170-
CPRINTS("ps8815: reg 0x0f now %02x", val);
171-
}
172-
173154
void board_reset_pd_mcu(void)
174155
{
175156
/* Port0 */
@@ -183,13 +164,9 @@ void board_reset_pd_mcu(void)
183164

184165
gpio_set_level(GPIO_USB_C0_TCPC_RST_ODL, 1);
185166
gpio_set_level(GPIO_USB_C1_RT_RST_R_ODL, 1);
167+
186168
/* wait for chips to come up */
187169
msleep(PS8815_FW_INIT_DELAY_MS);
188-
189-
/* Port1 */
190-
ps8815_reset();
191-
usb_mux_hpd_update(USBC_PORT_C1, USB_PD_MUX_HPD_LVL_DEASSERTED |
192-
USB_PD_MUX_HPD_IRQ_DEASSERTED);
193170
}
194171

195172
static void board_tcpc_init(void)

0 commit comments

Comments
 (0)