Added hide to tray on minimize option

[Devenor]

Added hide to tray on minimize option

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

closes #59

Description

Adds optional hide to system tray behaviour on minimizing the main window. The settings have an option to enable or disable it in the general section. The tray icon has a small menu for closing the app or opening the window again, and it can be opened by clicking on the icon too.

Screenshots

Screenshot is outdated, only hide to tray on minimize exists now.

Testing

• Go to Settings -> General and enable Minimize to system tray.
• When minimizing a window, the window will hide and a tray icon will appear.
• [Only on Windows] If there's only one window in the tray, left clicking the tray will open the window and the tray will disappear.
• Right clicking the tray will show a menu with an option to quit the app, and one submenu for each minimized window.
• Clicking the submenu will show one option to open the window and another to close it. When clicking an option, the submenu will disappear.
• If there are no more windows minimized, on Windows the tray will disappear, and on Linux it will remain with just the quit option.
• When a window is shown from the tray, it will retain its original size and position.
• When disabling the setting, if there are minimized windows they'll appear minimized in the taskbar.
• This setting is not avaliable for MacOS.

Desktop

• OS: Windows
• OS Version: 10
• FreeTube version: v0.23.2 Beta

Additional context

[absidue]

Please fix the build and revert all unrelated changes such as the dependency additions, there is no need to manually extract anything from the asar file and the translations are overkill at the moment (especially pulling in multiple dependencies just to translate 2 strings).

Even after the corrections there are still open questions such as how to handle multiple windows.

[Devenor]

Thanks for the review, I reverted the new dependencies (I didn't know you could read asar directly from node fs! It's much better now). About the i18n, if needed maybe we could send the translated text via IPC and recreate the tray.

As for how to handle multiple windows, I didn't know you could have more than one, is there some kind of setting for that?

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[absidue]

Looks like you may have mistakenly used npm instead of yarn to install the dependencies and pushed a package-lock.json file, additionally there seem to be changes to the yarn.lock file which shouldn't really be there as the dependencies are no longer changing in this PR.

[Devenor]

Well the Ubuntu VM is configured with low resources so i gave it max resources but that didnt improve the situation :(

Who knows then... I've already filed the report, let's see what they say.

In the meantime, would you be OK with trying to merge this increasing the timer or disabling it for Linux?

[Devenor]

@efb4f5ff-1298-471a-8973-3d47447115dc do you mind if I attach one of your videos showing the bug to the report? They are asking for one. Or you could do it yourself if you want, I won't be able until tomorrow.

[efb4f5ff-1298-471a-8973-3d47447115dc]

@Devenor go ahead and use the clips you need

[github-actions]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Hi @Devenor i noticed that the Electron report has been shot down but they did leave a suggestion on how to (maybe?) make it work. Is that useful to you?

[Devenor]

Hi @efb4f5ff-1298-471a-8973-3d47447115dc, I was hoping they'd respond to our replies, but I guess that won't happen... I’ll try in the next few days to see if what they suggested can actually be done.

[efb4f5ff-1298-471a-8973-3d47447115dc]

I was also hoping for that tbh :(

[Devenor]

After a bit of reading and testing, I think what they are suggesting is too complex to be worth it. But I found a more robust way to implement my workaround without the need of timers that seems promising, could you please test it? There shouldn't be any flickering either.

[efb4f5ff-1298-471a-8973-3d47447115dc]

There is a flicker sometimes to me that feels acceptable but i know that it could potentially trigger seizures for people with photosensitive epilepsy :sigh:

VirtualBoxVM_SLq0t1wzCz.mp4

[Devenor]

@efb4f5ff-1298-471a-8973-3d47447115dc can you please try again? I've found another workaround and after trying many times, I don't see any flicker. It's cleaner than the last one, too.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Passed all linux vms with flying colors!

[Devenor]

Can we finally merge this?

[efb4f5ff-1298-471a-8973-3d47447115dc]

@Devenor the others still need to review this but everybody is time constraint right now with life stuff. Please be patient

[PikachuEXE]

New custom build: https://github.com/PikachuEXE/FreeTube/actions/runs/16512658249

[PikachuEXE]

Tested with macOS & windows (but I don't use this feature regularly, I have no other multi-window app with minimize to tray

[github-actions]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[absidue]

Functionally everything seems to be working correctly, there are a few issues with the code such as commented out debug code and none of the code getting removed in the macOS build despite not being used, but as this pull request has been going on for so long and you have stuck with us to get it working I am willing to look past that and get this merged.

Thank you very much for your pull request, I am sorry that it took this long and I hope it hasn't discouraged your from wanting to contribute to FreeTube again in the future! LGTM :D

[Devenor]

Thanks a lot guys! Sorry about the code having a few flaws, I'd be happy to change it, but I see you've already taken care of it. I'll try to keep in mind those changes for my next contribution.

[efb4f5ff-1298-471a-8973-3d47447115dc]

@Devenor would you be interested in doing a followup PR. I noticed from my day to day use that if i want to open another instance of FT i need to open reopen my minimized instance from tray -> Now i can open an instance -> Minimize the instance to tray again -> use the newly opened instance

I think the tray would benefit from a option to open an instance directly similar to #7049

[Devenor]

Sure, looks like a nice feature, I'm in!

But if I'm not mistaken, #7049 just applies to Windows and MacOS, is there any issue with Linux?

[absidue]

Adding the button to the tray menu on Linux should be fine, the issue with adding it to the app icon menu on Linux was that some distros weren't showing FreeTube's button but were instead showing their own one that doesn't work with FreeTube: #7049 (comment)

[Devenor]

I see, usual Linux stuff... so, assuming it works in the tray, would you prefer to have the option there but not in the taskbar, rather than not having it at all? I guess it's better than nothing, but it could be a bit weird.

[efb4f5ff-1298-471a-8973-3d47447115dc]

I prefer to have it added to the tray

[DankestFke]

Can we have close for minimise to tray?