Use maxVideoPlaybackRate for the max value of Default Playback Rate#7184
Merged
FreeTubeBot merged 1 commit intoApr 14, 2025
Conversation
github-actions
Bot
added
the
PR: waiting for review
kommunarr
approved these changes
Apr 11, 2025
Collaborator
kommunarr
left a comment
kommunarr
left a comment
There was a problem hiding this comment.
Sliders values don't automatically auto adjust. It requires user interaction before it uses the new values. If user doesnt interact with the slider than the player also plays the value. Any ideas how we could address that?
I'm not sure if there's a cleaner way to do it, but what comes to mind is applying a custom rounding function on either an intermediary function call in player-settings.js or as a side effect handler through our system we have set up for that.
absidue
approved these changes
Apr 11, 2025
PikachuEXE
approved these changes
Apr 14, 2025
github-actions
Bot
removed
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
deleted the
fix-default-playback-rate
branch
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
maxVideoPlaybackRatefor the max value of Default Playback RatePull Request Type
Description
Default Playback Rate slider doesn't exceed max value set by Max Video Playback Rate slider
Testing
Desktop
Additional context
I noticed that the Default Playback Rate slider was set to max value of 8x but the Max Video Playback Rate slider goes up to 10x so i initially wanted to adjust that to 10x just to fix that inconsistency. Then i noticed that when I set the Max Video Playback Rate slider to 2x and i was able to set the Default Playback Rate slider to values >2x and the video player happily played at those speeds but didn't show them in the video player. So i guess a kind of 2 birds with one stone kind of situation here.
Also related but already existing behavior:
Sliders values don't automatically auto adjust. It requires user interaction before it uses the new values. If user doesnt interact with the slider than the player also plays the value. Any ideas how we could address that?
FreeTube_zxrKlKyXet.mp4