Adjust default playback rate to the maximum value when it is too large#7221
Merged
FreeTubeBot merged 1 commit intoMay 10, 2025
Merged
Conversation
PikachuEXE
previously approved these changes
Apr 17, 2025
Member
|
It should do the same when you adjust the Rate Interval VirtualBoxVM_c5ZR7jfbT8.mp4 |
Member
|
I would say that could be out of scope of this PR |
Member
|
This case was pointed out in #7184 and this PR is based on that. That case isnt implemented here by accident |
Member
|
Some context on how should it should be handled:
|
79efa19 to
4e11cc8
Compare
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
May 9, 2025
PikachuEXE
approved these changes
May 10, 2025
kommunarr
approved these changes
May 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust default playback rate to the maximum value when it is too large
Pull Request Type
Related issue
maxVideoPlaybackRatefor the max value of Default Playback Rate #7184 (review)Description
This pull request adjusts the default playback rate to the configured maxmium playback rate when the default is larger than it.
Testing
Desktop