Skip to content

Fix "more" button from sidenav not closing#7725

Merged
FreeTubeBot merged 2 commits into
FreeTubeApp:developmentfrom
caetano-dev:sidenavfix
Aug 8, 2025
Merged

Fix "more" button from sidenav not closing#7725
FreeTubeBot merged 2 commits into
FreeTubeApp:developmentfrom
caetano-dev:sidenavfix

Conversation

@caetano-dev
Copy link
Copy Markdown
Contributor

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Closes #7712

Description

This Pull Request fixes a bug that prevented the "more" navbar from closing when the user clicked on one of its elements or outside of it.

Testing

  1. Make your window small to see the navbar at the bottom with the "more" option available.
  2. Click on "more".
  3. Click on one of its options.
  4. See that it closes.
  5. Click on "more"
  6. Click outside of it
  7. See that it closes.

(previously, the "more" options would not close.)

Desktop

  • OS: Linux
  • OS Version: Ubuntu 24.04.2 LTS
  • FreeTube version: v0.23.5 Beta

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) July 22, 2025 15:53
@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 22, 2025
@caetano-dev caetano-dev changed the title Fix 'more' button not closing Fix "more" button from sidenav not closing Jul 22, 2025
@FreeTubeBot FreeTubeBot merged commit 553a1c7 into FreeTubeApp:development Aug 8, 2025
5 checks passed
@github-actions github-actions Bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 8, 2025
absidue added a commit to absidue/FreeTube that referenced this pull request Aug 9, 2025
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Aug 11, 2025
* development:
  Translated using Weblate (Serbian)
  Fix selecting a new quick bookmark playlist (FreeTubeApp#7803)
  Migrate DistractionSettings to the composition API (FreeTubeApp#7807)
  Use Array#find directly when parsing the chapters (FreeTubeApp#7808)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Croatian)
  change iina name to IINA (FreeTubeApp#7773)
  Remove `Export Playlists For Older FreeTube Versions` (FreeTubeApp#7195)
  Enhancement: Add fast forward and rewind pop up to video player (FreeTubeApp#7729)
  Fix "more" button from sidenav not closing (FreeTubeApp#7725)
  Fix handleSyncSubscriptionCache using the SYNC_PLAYLISTS IPC channel (FreeTubeApp#7756)
  Change Close button color to white (FreeTubeApp#7752)
  Migrate PlayerSettings to the composition API (FreeTubeApp#7766)
  Bump package version from 0.23.5 to 0.23.6 (FreeTubeApp#7794)
  Add shorts player parameters to help with 403s (FreeTubeApp#7763)
  Translated using Weblate (Norwegian Bokmål)
  Bump the stylelint group with 2 updates (FreeTubeApp#7779)
  Bump tmp from 0.2.1 to 0.2.4 (FreeTubeApp#7790)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: "... / More" menu stays open instead of closing as expected

5 participants