Skip to content

Respect watch history setting when opening in an external player#7853

Merged
FreeTubeBot merged 1 commit into
FreeTubeApp:developmentfrom
absidue:fix-external-player-watched
Aug 17, 2025
Merged

Respect watch history setting when opening in an external player#7853
FreeTubeBot merged 1 commit into
FreeTubeApp:developmentfrom
absidue:fix-external-player-watched

Conversation

@absidue
Copy link
Copy Markdown
Member

@absidue absidue commented Aug 16, 2025

Pull Request Type

  • Bugfix

Related issue

Introduced by: #7707

Description

When the feature to mark the videos as watched when they are opened in an external player was introduced, we forgot to check whether saving the watch history is actually enabled, this pull request rectifies that.

Testing

Please test opening a video in an external player in the following situations:

  1. From a video list e.g. subscriptions while remember watch history is turned OFF -> watch history should NOT be updated
  2. From a video list e.g. subscriptions while remember watch history is turned ON -> watch history should be updated
  3. From the watch page while remember watch history is turned OFF -> watch history should NOT be updated
  4. From the watch page while remember watch history is turned ON -> watch history should be updated

Desktop

  • OS: Windows
  • OS Version: 10

@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 16, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 16, 2025 13:02
@FreeTubeBot FreeTubeBot merged commit 94281bf into FreeTubeApp:development Aug 17, 2025
5 checks passed
@github-actions github-actions Bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 17, 2025
@absidue absidue deleted the fix-external-player-watched branch August 17, 2025 15:00
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Aug 19, 2025
* development: (22 commits)
  Translated using Weblate (Persian)
  Fix show added items not working for hide videos from channels (FreeTubeApp#7854)
  Respect watch history setting when opening in an external player (FreeTubeApp#7853)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Japanese)
  Translated using Weblate (Hebrew)
  Translated using Weblate (Romanian)
  Translated using Weblate (Estonian)
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Italian)
  Translated using Weblate (Czech)
  Translated using Weblate (Portuguese (Brazil))
  Migrate FtSelect to the composition API (FreeTubeApp#7847)
  Translated using Weblate (Bulgarian)
  Translated using Weblate (German)
  Translated using Weblate (Hungarian)
  Translated using Weblate (French)
  Added hide to tray on minimize option (FreeTubeApp#6915)
  Add support for parsing premiere video LockupViews (FreeTubeApp#7848)
  Bump package version from 0.23.6 to 0.23.7 (FreeTubeApp#7849)
  ...

# Conflicts:
#	src/renderer/helpers/api/local.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants