Set millisecond field to 0 if not specified in the input of parseRfc3339.

rmistry · rmistry · commit aa48f482a681 · 2012-02-10T08:58:14.000-08:00
diff --git a/google-http-client/src/main/java/com/google/api/client/util/DateTime.java b/google-http-client/src/main/java/com/google/api/client/util/DateTime.java
@@ -216,6 +216,7 @@ public static DateTime parseRfc3339(String str) throws NumberFormatException {
           dateTime.set(Calendar.MILLISECOND, milliseconds);
           tzIndex = 23;
         } else {
+          dateTime.set(Calendar.MILLISECOND, 0);
           tzIndex = 19;
         }
       }
diff --git a/google-http-client/src/test/java/com/google/api/client/util/DateTimeTest.java b/google-http-client/src/test/java/com/google/api/client/util/DateTimeTest.java
@@ -53,6 +53,8 @@ public void testParseDateTime() {
     assertTrue(value.isDateOnly());
     value = DateTime.parseRfc3339("2007-06-01T10:11:30.057");
     assertFalse(value.isDateOnly());
+    value = DateTime.parseRfc3339("2007-06-01T10:11:30Z");
+    assertEquals(0, value.getValue() % 100);
   }
 
   private void expectExceptionForParseRfc3339(String input) {

Original file line number	Diff line number	Diff line change
`@@ -216,6 +216,7 @@ public static DateTime parseRfc3339(String str) throws NumberFormatException {`
`216`	`216`	`dateTime.set(Calendar.MILLISECOND, milliseconds);`
`217`	`217`	`tzIndex = 23;`
`218`	`218`	`} else {`
	`219`	`+ dateTime.set(Calendar.MILLISECOND, 0);`
`219`	`220`	`tzIndex = 19;`
`220`	`221`	`}`
`221`	`222`	`}`
Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,8 @@ public void testParseDateTime() {`
`53`	`53`	`assertTrue(value.isDateOnly());`
`54`	`54`	`value = DateTime.parseRfc3339("2007-06-01T10:11:30.057");`
`55`	`55`	`assertFalse(value.isDateOnly());`
	`56`	`+ value = DateTime.parseRfc3339("2007-06-01T10:11:30Z");`
	`57`	`+ assertEquals(0, value.getValue() % 100);`
`56`	`58`	`}`
`57`	`59`
`58`	`60`	`private void expectExceptionForParseRfc3339(String input) {`